Skip to content

F
FMC ADC 100M 14b 4cha
Commit 7ab1e9a1 authored by Federico Vaga's avatar Federico Vaga
Browse files
Options

sw:drv: accept only 16bit offset values 

Signed-off-by: Federico Vaga's avatarFederico Vaga <federico.vaga@cern.ch>
parent e44b9ae1
Hide whitespace changes
Inline Side-by-side
Showing with 19 additions and 0 deletions
software/kernel/fa-zio-drv.c
View file @ 7ab1e9a1
......@@ -203,6 +203,12 @@ static int zfad_conf_set(struct device *dev, struct zio_attribute *zattr,
/*fallthrough*/
case ZFA_SW_CH4_OFFSET_ZERO:
i--;
if (usr_val & 0xFFFF0000) {
dev_err(dev,
"Offset must be a 16bit unsigned value (0x%08x)\n",
usr_val);
return -EINVAL;
}
spin_lock(&fa->zdev->cset->lock);
fa->zero_offset[i] = usr_val;
err = fa_calib_dac_config_chan(fa, i, 0, FA_CALIB_FLAG_READ_TEMP);
......@@ -234,6 +240,12 @@ static int zfad_conf_set(struct device *dev, struct zio_attribute *zattr,
/*fallthrough*/
case ZFA_CH4_OFFSET:
i--;
if (usr_val & 0xFFFF0000) {
dev_err(dev,
"Offset must be a 16bit unsigned value (0x%08x)\n",
usr_val);
return -EINVAL;
}
spin_lock(&fa->zdev->cset->lock);
fa->user_offset[i] = usr_val;
err = fa_calib_dac_config_chan(fa, i, 0,
......@@ -242,6 +254,13 @@ static int zfad_conf_set(struct device *dev, struct zio_attribute *zattr,
return err;
case ZFA_CHx_OFFSET:
chan = to_zio_chan(dev);
if (usr_val & 0xFFFF0000) {
dev_err(dev,
"Offset must be a 16bit unsigned value (0x%08x)\n",
usr_val);
return -EINVAL;
}
spin_lock(&fa->zdev->cset->lock);
fa->user_offset[chan->index] = usr_val;
err = fa_calib_dac_config_chan(fa, chan->index, 0,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment