This time I added -Wmissing-prototypes and fixed accordingly. Again, this
used to be part of -Wall and I'm disgusted by it not being so any more.

What does "all" mean, then?

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

I added -Wstrict-prototypes, that used to be included in -Wall settings
but is not.  Actually, I think it should be an error to not specify an
argument list by now.  If any, -traditional is there for old timers.

Fortunately no bug was exposed by the missing prototypes.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Yesterday I was eventually fussed up by the need to "make clean" every
time. So here's a stupid depend rule, not perfect but better than
nothing.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Adam Wujek authored 9 years ago and Grzegorz Daniluk committed 9 years ago

Add checking stack overflow and detecting reset to wrs. Code common for wrpc
and wrs is placed in system_checks.c and .h. Work is based on following
commits in wrc_main.c:
1704a668 main: check for stack overflow
7836c39e

 Optionally detect reset and print a stack trace

Additionally:
--update Kconfig to have a possibility to select CHECK_RESET also for switch,
  not only for node as before
--and _endram to ram-wrs.ld

When "stack overflow" occurs then message is printed once every second.
When reset occours then LM32 will print stack trace and reset once more.
NOTE: I couldn't get spll to work after reset, for sure problem is in
      ad9516 init function, but not only there.

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Adam Wujek authored 9 years ago and Grzegorz Daniluk committed 9 years ago

--increase spll_stats structure version to 2
--add to spll_stats structure:
  - commit_id
  - build_date
  - build_time
  - start_cnt (to be used later for start counter)
--move declaration of spll_stats structure from wrs_main.c to revision.c
--pass git version and author at compile time to revision.c
--create revision.h with build_* externs
--update version reporting at cpu start
--update version command
--include section .stats in section .data for node

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Theodor-Adrian Stana authored 11 years ago and Grzegorz Daniluk committed 10 years ago

The flash-write tool is operational. The call to read status register
from flash-host is not working yet, and that is to be solved. In the
meantime, there are sleep functions inserted where we're supposed
to poll the status register.

Signed-off-by: Theodor Stana <t.stana@cern.ch>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Pietro Fezzardi authored 10 years ago and Alessandro Rubini committed 10 years ago

This adds 2.3kB to the GSI configuration, beause it enable ptpdump.
Earlier it was always forces off, due to wrong comparison of ram size.

Alessandro Rubini authored 11 years ago and Grzegorz Daniluk committed 10 years ago

This includes ppsi-v2014.07.

The new ppsi master is Kconfig-based, so our makefile must
make "wrpc_defconfig" in ppsi before building it.
Additionally, the link steps changed to the better in there, so we
don't link the "strange" $(PPSI)/proto-standard/libstd.a any more.

We may consider whether a local .config for ppsi should be
provided by this package instead of relying on its own choices;
not a big deal, though, as we maintain them at the same time.

Please note that any existent ppsi/.config is preserved, to allow
local tests. This should not have any impact on normal users.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

ram.ld must be rebuilt every time the configuration changes. It was
supposed to be like that, but it was not.

So, the older ram.ld was used when first building with a new config,
and only the second time the rule was used. This was exposed by
failuers in ./MAKEALL where each configuration is built only once.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This fixes the makefile to build either wrc.bin or rt_cpu.bin, using
the obj-y convention. At this point Kconfig can't select rt_cpu.bin,
and nothing changes in the ouput binary, in all configurations.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Etherbone won't fit with a full ppsi in the default RAM size for SPEC
cards. So this commit uses a ppsi hack to avoid internal ptpdump,
activating it when CONFIG_RAMSIZE is not 128kB and CONFIG_ETHERBONE is
set.

We should rather compare RAMSIZE with "< 131072", but neither gnu make
nor this version of Kconfig support numeric comparison.

This hack will soon disappera, as ppsi is gaining Kconfig support, so
wrpc-sw will be able to pass proper configuration. Also, 128kB will soon
be the default for SPEC images.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

These headers shadow system headers.
While they are necessary for building on the LM32, it breaks any
code that wants the other WR headers on a different architecture.

By moving these headers, we can pick whether to use them or not.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This is needed to build sdb-lib for the target, in case you rely on
the default value for CROSS_COMPILE instead of using the environment
variable.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

We don't want to call the real printf, which brings in the whole of
newlib, but it sometimes happen. So let's diagnose the problem
immediately rather than letting users wonder what is wrong with the
size.

Similarly, if building under ppsi, ensure we are not calling libgcc
division functions: any 64-bit division my be done with __div64_32
offered by ppsi/lib (copied from the kernel).

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

With this commit, when you select both the hardware and software uart,
ppsi diagnostics (controlled  by the "verbose" command) got to
the software uart, not to the hardware one. In this way you can run
the shell in a clean tty.

Unfortunately, frame dumps still reach the hardware uart, if frame
verbosity is greater than 1.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

We need to link ppsi/proto-standard/libstd.a explicitly, but we also
need a rule to generate it, or parallel compilation fails saying it
has no rule. The makefile depended on build order (my fault), as
building ppsi/ppsi.o, with its rule), also built libstd.a

BTW, this removes ppsi/arch-wrpc/libarch.a from the dependencies,
because it is already linked in making ppsi/ppsi.o (otoh the need for
an explicit mention of libstd.a can't easily be solved in ppsi
itself, so it remains here).

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

In recent ppsi code, proto-ext-whiterabbit is not replicating
proto-standard any more, but rather it offers hooks for the additional
code it needs.  Thus, we need to link the library for standard PTP as
well, to pick some of the states for the WR state machine.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This source file is now part of ppsi itself, so it is removed from
wrpc-sw. The move helps improving cleaning up and maintaing ppsi
without committing to the supermodule each time something internal changes.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Cesar Prados authored 11 years ago and Alessandro Rubini committed 11 years ago

Split a rule into two rules, to make make happy.

In previous versions of make it was acceptable to list one or more
explicit targets followed by one or more pattern targets in the same
rule and it worked "as expected". However, this was not documented as
acceptable and if you listed any explicit targets AFTER the pattern
targets, the entire rule would be mis-parsed. This release removes
this ability completely: make will generate an error message if you
mix explicit and pattern targets in the same rule. You must split
these rules into two rules: one for the pattern and one for the
explicit targets. The Linux kernel source has already been modified in
this way (in newer kernels).

This is a copy of ptp-noposix/libposix/freestanding-wrapper.c, moved
into this project because it actually is only used here. The Makefile
now builds this one.

This move is needed in order to remove this faulty usleep and provide a
better one, while keeping the other fake functions called by ptp-noposix
code.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This command can return the .config file to the user. It can be useful
to trace what is actually running, as addition to the "ver"
command.  It is optional because it costs .5kB of binary size.

Example:

  wrc# config
    Current WRPC-SW configuration:
  CONFIG_RAMSIZE=90112
  # CONFIG_PTP_NOPOSIX is not set
  CONFIG_PPSI=y
  # CONFIG_CHECK_RESET is not set
  CONFIG_PPSI_VERBOSITY=0
  CONFIG_PPSI_RUNTIME_VERBOSITY=y
  CONFIG_STACKSIZE=2048
  CONFIG_PP_PRINTF=y
  # CONFIG_PRINTF_FULL is not set
  CONFIG_PRINTF_XINT=y
  # CONFIG_PRINTF_MINI is not set
  # CONFIG_PRINTF_NONE is not set
  CONFIG_PRINT_BUFSIZE=128
  CONFIG_ETHERBONE=y
  # CONFIG_DETERMINISTIC_BINARY is not set
  CONFIG_CMD_CONFIG=y

(This configuration amounts to a binary size of 86252 bytes, at this
commit).

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This commit makes no effect, but it prepares for the following one.
In general, using an intermediate platform-agnostic linker script
when making wrc.o is not bad, so let's do it here.

The main reason why we need it is to force the "KEEP" command for the
".cmd" ELF section, introduced by the next commit.  The alternative to
this would be chaning the main linker script, which is worse in my
opinion.

If we add initcalls or similar stuff later, this bigobj.lds is the
place to do it.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

New procedure that does not require PTP traffic, is much faster and doesn't kill the stack.
Requires recent endpoint version (wr-cores commit: 4713a98a).
Todo: modify locking functions in libptpnetif to automatically perform the calibration whenever
PTP enters slave mode.

Alessandro Rubini authored 12 years ago and Grzegorz Daniluk committed 12 years ago

The ppsi subproject now builds pp_printf by default, so the Makefile here
passes ~CONFIG_NO_PRINTF=y". Also, assign_TimeInternal() is not there
any more because it is just an assignment.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>