This time I added -Wmissing-prototypes and fixed accordingly. Again, this
used to be part of -Wall and I'm disgusted by it not being so any more.

What does "all" mean, then?

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

I added -Wstrict-prototypes, that used to be included in -Wall settings
but is not.  Actually, I think it should be an error to not specify an
argument list by now.  If any, -traditional is there for old timers.

Fortunately no bug was exposed by the missing prototypes.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Yesterday I was eventually fussed up by the need to "make clean" every
time. So here's a stupid depend rule, not perfect but better than
nothing.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This adds two commands: devemem (to read and write registers/RAM)
and delays (to read and change the constant delays.  The commands are
only available for CONFIG_DEVELOPER builds.

The default delays were just wrong, they are valid of an older
gateware version.  Using 0, it is clearer to the user that the right
value is missing (if the SFP database is populated, the right value
applies anyways).

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Grzegorz Daniluk authored 9 years ago and Alessandro Rubini committed 9 years ago

Otherwise we have a race condition with wr_date setting initial time on the
switch.

Adam Wujek authored 9 years ago and Grzegorz Daniluk committed 9 years ago

in ppsi:
--update hal_shmem to version 7
--add tx and rx packet counters
--add error counters for SNMP
--increase ppsi shmem version to 6

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Adam Wujek authored 9 years ago and Grzegorz Daniluk committed 9 years ago

remove waiting state, make waiting flag instead

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Adam Wujek authored 9 years ago and Grzegorz Daniluk committed 9 years ago

Add checking stack overflow and detecting reset to wrs. Code common for wrpc
and wrs is placed in system_checks.c and .h. Work is based on following
commits in wrc_main.c:
1704a668 main: check for stack overflow
7836c39e

 Optionally detect reset and print a stack trace

Additionally:
--update Kconfig to have a possibility to select CHECK_RESET also for switch,
  not only for node as before
--and _endram to ram-wrs.ld

When "stack overflow" occurs then message is printed once every second.
When reset occours then LM32 will print stack trace and reset once more.
NOTE: I couldn't get spll to work after reset, for sure problem is in
      ad9516 init function, but not only there.

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Adam Wujek authored 9 years ago and Grzegorz Daniluk committed 9 years ago

--increase spll_stats structure version to 2
--add to spll_stats structure:
  - commit_id
  - build_date
  - build_time
  - start_cnt (to be used later for start counter)
--move declaration of spll_stats structure from wrs_main.c to revision.c
--pass git version and author at compile time to revision.c
--create revision.h with build_* externs
--update version reporting at cpu start
--update version command
--include section .stats in section .data for node

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Adam Wujek authored 10 years ago and Grzegorz Daniluk committed 9 years ago

Do not report to monitor oscilations between state WR_WAIT_SYNC_IDLE and
TRACK_PHASE. Real problem will be fixed later.

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Adam Wujek authored 10 years ago and Grzegorz Daniluk committed 9 years ago

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Adam Wujek authored 10 years ago and Grzegorz Daniluk committed 9 years ago

Needed since ppsi moved to shmem and removed cur_servo_state structure from
servo.

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Adam Wujek authored 10 years ago and Grzegorz Daniluk committed 9 years ago

ppsi for wrs requres locks in shmem when shmem is changing. Since servo is
shared between wrs and wrpc fixes had to be implemented.
Since there is no shmem in wrpc, dummy function for locking had to be added.
As a side effect include/libwr/shmem.h was added.

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Adam Wujek authored 10 years ago and Grzegorz Daniluk committed 9 years ago

pass of header cleanup from wrs

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Adam Wujek authored 10 years ago and Grzegorz Daniluk committed 9 years ago

Done as a part of work to move hal to shm in wrs.

Done in this commit:
--use wrpc_get_port_state instead of halexp_get_port_state
--make wrpc_get_port_state fill hal_port_state structure in the way how HAL
  fills shmem.
--update lib/net.c to use struct hal_port_state instead of hexp_port_state_t
--update monitor/monitor_ppsi.c to use struct hal_port_state instead of
  hexp_port_state_t
--update ppsi to get needed changes

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Adam Wujek authored 10 years ago and Grzegorz Daniluk committed 9 years ago

Files needed to get rid of halexp_get_port_state.
Done during process of moving HAL to shm in wrs.

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Adam Wujek authored 10 years ago and Grzegorz Daniluk committed 9 years ago

It is not used anymore.

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Adam Wujek authored 10 years ago and Grzegorz Daniluk committed 9 years ago

Update include/hal_exports.h to latest version

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Adam Wujek authored 10 years ago and Grzegorz Daniluk committed 9 years ago

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

This is useful for example when using a secondary onewire controller.

This reverts commit 7e2ee9b4.

You can't put a bitstream into the middle of a tiny EEPROM.
If you intend to build an sdbfs for a switch, make a new image.

It's a preparation for flash support, as there we cannot update
bytes/entries count without erasing entire flash sector.