Federico Vaga authored 8 years ago and Adam Wujek committed 8 years ago

Copy the vic IRQ controller from the coht-vic repository.
The maintainer prefers to have a copy instead of a submodule.

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

Federico Vaga authored 8 years ago and Adam Wujek committed 8 years ago

Many mach headers has been moved out of scope. Of course they are still
accessible by in an ugly way. Here I'm following the ugly way in order
to get something working.

What to do with this headers, perhaps, needs a discussion. I personally
think that we need our local headers with hardware definitions. The
reason is that we saw that in future kernel version some of these
headers complitely disappear. The hardware definitions never change so
we can safely copy them and remove a dependency with an external project.

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

Federico Vaga authored 8 years ago and Adam Wujek committed 8 years ago

Instead of using clocksource_register() we use
clocksource_register_hz() as suggested

From kernel patch c7f798e3722610d486e951f04bbc00b6ba124d62
    clocksource: Get rid of clocksource_calc_mult_shift()

    No one is using this, so encourage the use of
    clocksource_register_hz/khz(), and drop this helper.

    Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
    [jstultz: tweaked commit message]
Signed-off-by: John Stultz <john.stultz@linaro.org>

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

Federico Vaga authored 8 years ago and Adam Wujek committed 8 years ago

On modern switches the fan are driver by a dedicated FPGA core
that does the PWM. This module is not necessary anymore and not even
the kernel patches to make this module work.

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

Federico Vaga authored 8 years ago and Adam Wujek committed 8 years ago

Today it is not really important to do this because all our modules are
within the project itself. But, at somepoint, we may use submodules
in order to integrate drivers from external sources; so, we need to export
our default values because we will not have control over the other projects

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

Federico Vaga authored 8 years ago and Adam Wujek committed 8 years ago

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

Federico Vaga authored 8 years ago and Adam Wujek committed 8 years ago

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

The tool wrs_port_tx_control is not needed anymore, its functionality (putting
the link down) is available by performing:
ifconfig <port> down
Such functionality was added in the commit:
[Feature: 1336] kernel/wr_nic: disable SFP when interface is down

Revert the following commits:
2b6c0bc2 userspace/tools: wrs_port_tx_control, rename network interfaces from wrX to wriX+1
ceb0c512 userspace/tools/wrs_port_tx_control: Include some defines
97d8878d userspace/tools/wrs_port_tx_control: initialise register address
35a63cd9 kernel/wb-regs: Added address offsets to endpoint-mdio.h
d11514e5 userspace/tools/wrs_port_tx_control: added unistd.h
3184c2a7 doc/wrs-user-manual: added description of wrs_port_tx_control
4da29df3 userspace/tools: dynamically check maximum port number in wr_port_tx_control
4244c894

 userspace/tools: added a program to control the TX on a WRS port

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Keep low enable pin on SFP when the interface is down.
This commit makes the wrs_port_tx_control tool not needed anymore.

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

get rid of warning:
WARNING: "wr_nic_pstats_callback" [/home/awujek/wrs/wr-switch-sw/kernel/wr_pstats/wr_pstats.ko] undefined!

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Use 16 as length of wrint_name to let Alessandro sleep well.

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Tjeerd Pinkert authored 9 years ago and Adam Wujek committed 8 years ago

FIXME: I know that this is not the place to add these definitions
    they should be added/fixed in the .wb files.

FIXME:
- fixed #ifndef statement, the dash makes the compiler ignore the MDIO_WB
  part, which does not allow the file to be #included together with the
  endpoint-regs.h file. This should be done in the .wb file.

FIXME:
- added register address constants. This should be done in the .wb file

Note: I have no idea how to do this, someone who knows could probably fix
    the issues raised here.

Apply zero bias at every read from FPGA.

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

zeros keep only value read from FPGA at zeroing. The rest can be zeroed simply
in software.

Change the size of cntrs and userv from unsigned long long to uint64_t.

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Because 32bit kernel does not export 64bit values via sysctl in a easy way,
each pstats counter is split into two 32bit values which have to assembled into
one value in software that reads pstats counters.

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Set-up VLAN related registers during driver load instead of during opening
(bringing up) interfaces.
From now VLANs can be configured after loading the driver, but before bringing
up of interfaces. By this no switching is done without VLANs beeing configured.

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Alessandro Rubini authored 9 years ago and Adam Wujek committed 9 years ago

When the switch is loaded, some PTP outgoing frames get discarded, so we
never get back the timestamp interrupt.  By round-robin'ing the slots,
we get back to the "busy" one, which holds an skb structure that must be
released.

Without this freeing, the skb remains in the output queue of the
socket, and after a while we get EAGAIN in send() because the buffer
is full (400 frames, more or less). And the ptp port is stuck until we
reopen the socket.

This diagnosis exposed the fact that it's not an overflow of pending
descriptors, so I change the message from

  descriptor overflow: tx timestamp pending

to

  discarding tx frame that got no timestamp

Finally, this is pr_warn, not pr_err as we now know it's expected.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Alessandro Rubini authored 9 years ago and Adam Wujek committed 9 years ago

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Add reporting via ifconfig:
--rx errors (counter RX PCS Errors from pstats)
--carrier (counter RX Sync Lost from pstats)

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Otherwise, the port files are empty, even if pstats/info is correct

  wrs-192.168.16.9#wc -c /proc/sys/pstats/*
      529 /proc/sys/pstats/description
        7 /proc/sys/pstats/info
        0 /proc/sys/pstats/port0
        0 /proc/sys/pstats/port1
        0 /proc/sys/pstats/port10
        0 /proc/sys/pstats/port11
        0 /proc/sys/pstats/port12
        0 /proc/sys/pstats/port13
        0 /proc/sys/pstats/port14
        0 /proc/sys/pstats/port15
        0 /proc/sys/pstats/port16
        0 /proc/sys/pstats/port17
        0 /proc/sys/pstats/port2
        0 /proc/sys/pstats/port3
        0 /proc/sys/pstats/port4
        0 /proc/sys/pstats/port5
        0 /proc/sys/pstats/port6
        0 /proc/sys/pstats/port7
        0 /proc/sys/pstats/port8
        0 /proc/sys/pstats/port9
      536 total

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

get rid of constants: PSTATS_CNT_PP and PSTATS_ADR_PP
Use number of ports read from FPGA instead of PSTATS_NUM_OF_COUNTERS

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Read is done at module init.

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Masking is not needed since uint32_t << 32 zero all lower bits.

Reported-by: Alessandro Rubini <rubini@gnudd.com>
Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Changes also in wr_pstats.
Wr_nic now calls callback function in wr_pstats to get counters

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Alessandro Rubini authored 10 years ago and Adam Wujek committed 10 years ago

By writing anything to a port file, you zero the counters for that
port. By writing to "info" or "description" you zero counters for
all ports.

Zeroing is performed by copying the current values to a new array,
and always subytracting that array to the current counter values.

No zeroing is performed for network statistics, that still reads
the "real" counters, featuring an overflow at 4G but no zeroing ever.

To simplify a little the code, I turned the one-dimensional array
with index arithmetics into a two-dimensional array, so the compiler
makes the math for us, transparently.

NOTE: the spinlock must be audited, we are not safe yet, not only
because of this patch.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Alessandro Rubini authored 10 years ago and Adam Wujek committed 10 years ago

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Alessandro Rubini authored 10 years ago and Adam Wujek committed 10 years ago

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>