Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Sign in
P
Platform-independent core collection
  • Project
    • Project
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 9
    • Issues 9
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • Wiki
    • Wiki
  • image/svg+xml
    Discourse
    • Discourse
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • Projects
  • Platform-independent core collection
  • Merge Requests
  • !6

Closed
Opened Apr 07, 2020 by Olof Kindgren@olofk
  • Report abuse
Report abuse

Cleanup includes

Removes some unnecessary includes with the goal of not having any files in common depending on outside files.

There is still one issue left after this. gc_delay_line uses generic_dpram from genrams. The only user of gc_delay_line seems to be gc_moving_average. So my question is, does anything at all use gc_delay_line or gc_moving_average? If not, perhaps remove this. Otherwise, can we move them somewhere else?

Edited Apr 09, 2020 by Dimitris Lampridis

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b cleanup_includes origin/cleanup_includes

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/proposed_master
git merge --no-ff cleanup_includes

Step 4. Push the result of the merge to GitLab

git push origin proposed_master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 5
  • Commits 1
  • Changes 6
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: project/general-cores!6