sdb: fix nibble order in commit_id field of SDB synthesis record. Closes #1399.

This was due to a bug in the f_string2bits() which took the commit ID as a string argument, assuming that the character array of the string is (32 downto 1), while in fact the commit_id is a string(1 to 32). f_string2bits() is now more resilient, it works with both "up" and "downto" string arguments, by checking the "ascending" attribute of the string type.

sdb: fix nibble order in commit_id field of SDB synthesis record. Closes #1399.
This was due to a bug in the f_string2bits() which took the commit ID as a string argument, assuming that the character array of the string is (32 downto 1), while in fact the commit_id is a string(1 to 32). f_string2bits() is now more resilient, it works with both "up" and "downto" string arguments, by checking the "ascending" attribute of the string type.
2943524e · Dimitris Lampridis · 4ec58596 · 2943524e
Commit 2943524e authored Oct 27, 2016 by Dimitris Lampridis
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

wishbone_pkg.vhd modules/wishbone/wishbone_pkg.vhd +5 -1

No files found.
--- a/modules/wishbone/wishbone_pkg.vhd
+++ b/modules/wishbone/wishbone_pkg.vhd
@@ -1794,7 +1794,11 @@ package body wishbone_pkg is
        when 'F' => nibble := X"F";
        when others => nibble := "XXXX";
      end case;
-      slv(((i+1)*4)-1 downto i*4) := nibble;
+      if s'ascending then
+        slv(slv'length-(i*4)-1 downto slv'length-(i+1)*4) := nibble;
+      else
+        slv(((i+1)*4)-1 downto i*4) := nibble;
+      end if;
    end loop;
    return slv;
  end f_string2bits;