- Feb 12, 2024
-
-
Federico Vaga authored
Signed-off-by:Federico Vaga <federico.vaga@cern.ch>
-
Federico Vaga authored
The carrier device release function and the fmc_carrier_register error handling process were freeing the IDA is twice. Signed-off-by: -
Federico Vaga authored
The device release function and the fmc_carrier_add_slot error handling process were freeing the IDA is twice. Somehow, the id triggered a NULL pointer bug. Not clear where that comes from, but fixing the error management fixed the NULL pointer reference as well (I think, but I do not have time to investigate further). Signed-off-by:
-
- Oct 12, 2023
-
-
Federico Vaga authored
Signed-off-by: -
Federico Vaga authored
tools: lib: fix path for installation Closes #11 See merge request be-cem-edl/fec/hardware-modules/fmc!7
-
Vaibhav Gupta authored
Signed-off-by:Vaibhav Gupta <vaibhav.gupta@cern.ch>
-
Federico Vaga authored
Signed-off-by: -
Federico Vaga authored
Resolve "rebuild for debian 12 and install" Closes #11 See merge request be-cem-edl/fec/hardware-modules/fmc!6
-
Vaibhav Gupta authored
Signed-off-by: -
Vaibhav Gupta authored
Signed-off-by: -
Vaibhav Gupta authored
If sphinx not found, make recipe will fail and it will throw error. Hence CI will also fail. Signed-off-by: -
Vaibhav Gupta authored
Signed-off-by: -
Vaibhav Gupta authored
Signed-off-by: -
Vaibhav Gupta authored
Signed-off-by:
-
- Sep 04, 2023
-
-
Federico Vaga authored
Resolve "Make the root makefile uniform with other projects" Closes #10 See merge request be-cem-edl/fec/hardware-modules/fmc!5
-
Vaibhav Gupta authored
Signed-off-by:
-
- Aug 31, 2023
-
-
Federico Vaga authored
Resolve "Use fec-build-sw to build FMC" Closes #9 See merge request be-cem-edl/fec/hardware-modules/fmc!4
-
Vaibhav Gupta authored
Signed-off-by: -
Vaibhav Gupta authored
Signed-off-by: -
Vaibhav Gupta authored
Signed-off-by: -
Vaibhav Gupta authored
Signed-off-by: -
Vaibhav Gupta authored
Signed-off-by: -
Vaibhav Gupta authored
Signed-off-by: -
Vaibhav Gupta authored
The targets were explicitly listed and had separate make commands for each of the directories which could be combined into one. Putting the directories in a common variable will also help to implement 'flawfinder' and 'cppcheck' at later stages. Signed-off-by:
-
- Jun 12, 2023
-
-
Federico Vaga authored
Resolve "at24 module should be loaded before FMC probe" Closes #8 See merge request be-cem-edl/fec/hardware-modules/fmc!3
-
Vaibhav Gupta authored
In cases where driver modules are not built into the kernel itself, at24 module is not loaded at the desired time, and thus, can cause error when trying to read the eeprom. Also, listing at24 as a soft dependency doesn't solves our problem as it does not guarantees the time at which the module will be loaded. Hence, load the module using request_module(), and throw a kernel warning in syslog if it fails. Signed-off-by:
-
- Nov 07, 2022
-
-
Federico Vaga authored
Signed-off-by: -
Federico Vaga authored
Resolve "fix documentation" Closes #2 See merge request be-cem-edl/fec/hardware-modules/fmc!2
-
Federico Vaga authored
Signed-off-by: -
Federico Vaga authored
Signed-off-by: -
Federico Vaga authored
Resolve "Review Vaibhav Patches" Closes #1 See merge request be-cem-edl/fec/hardware-modules/fmc!1
-
- Nov 04, 2022
-
-
Vaibhav Gupta authored
Signed-off-by: -
Vaibhav Gupta authored
Signed-off-by: -
Federico Vaga authored
On error, set the slot->nvmem to NULL. This keeps the data structure in line with the real status (the nvmem device was not found). Reported by: Federico Vaga <federico.vaga@cern.ch> Signed-off-by: -
Vaibhav Gupta authored
Signed-off-by: -
Vaibhav Gupta authored
Signed-off-by: -
Vaibhav Gupta authored
Signed-off-by: -
Vaibhav Gupta authored
With nvmem framework, the reference counter of the nvmem device is increased when we ask the device from the kernel via helper functions like "nvmem_device_find()", "nvmem_device_get()", etc. If reference count is zero, the driver can be unloaded (rmmod) during ongoing operations. Thus, the reference count should be incremented during add, and decremented during delete. Reported-by:
-
Vaibhav Gupta authored
-
- Oct 25, 2022
-
-
Federico Vaga authored
Signed-off-by:
-
