We have not been using mprintf for ages now, and it's better for the
code to explicitly call pp_printf, so people is aware of it.

We might "#define printf pp_printf", but currently we'd better not.
Maybe when we turn this into a real operating system, next millennium...

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

The gui is timely: it refreshes every that many seconds, but I'd
better see a change immediated when it happens.  This commit
introduces monitoring of the wr-servo update count, so if anything
changed an information scree is dumped.

This is different from stats (two commits ago), because we want to
refresh timely in any case, so the user sees the thing is active.

You can verify the effect of the commit after "refresh 4": timely
refresh is now slower than servo updated and you'll see how gui
updates are synced with the ptp protocol.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

With the new "only print if sth happens" way, sometimes stats is
just silent forever. This happens if we are master or if no slave
is active (well, and during initial setting up the wr link).

So now typing "stat" or "stat on" will turn on stats and print a line
of statistics, every time -- or the line "statistics now off".
This happens by changing the internal status of monitor_ppsi.c,
now exported to the cmd_stat.c.

This is the result on a master system:

   wrc# stat
   lnk:1 rx:0 tx:3 lock:1 sv:0 ss:'' aux:1 sec:5 [...]
   wrc#
   wrc#
   wrc# stat
   statistics now off
   wrc#
   wrc#
   wrc# stat
   lnk:1 rx:0 tx:11 lock:1 sv:0 ss:'' aux:1 sec:8 [...]
   wrc#
   wrc#

And this is what happens when we become slave:

   wrc# mode slave
   Locking PLL
   wrc# ptp start
   Slave Only, clock class set to 255
   wrc# lnk:1 rx:57 tx:60 lock:1 sv:1 ss:'SYNC_SEC' aux:1 sec:49 [...]
   lnk:1 rx:70 tx:64 lock:1 sv:1 ss:'SYNC_NSEC' aux:1 sec:1444901411 [...]
   lnk:1 rx:77 tx:66 lock:1 sv:1 ss:'SYNC_PHASE' aux:1 sec:1444901414 [...]
   lnk:1 rx:83 tx:68 lock:1 sv:1 ss:'WAIT_OFFSET_STABLE' aux:1 sec:1444901416 [...]
   lnk:1 rx:87 tx:69 lock:1 sv:1 ss:'WAIT_OFFSET_STABLE' aux:1 sec:1444901417 [...]
   lnk:1 rx:90 tx:70 lock:1 sv:1 ss:'TRACK_PHASE' aux:1 sec:1444901418 [...]
   lnk:1 rx:94 tx:71 lock:1 sv:1 ss:'TRACK_PHASE' aux:1 sec:1444901419 [...]

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This change monitors the update_count of wr_servo, and only prints
a statistics line when something happens.

This means we won't have long "TRACK_PHASE" listings when the master
is dead. Moreover, we see changes when they happen, not at a random
time during the next second.

The bad side of the thing is that if nothing happens in the wr servo,
nothing is ever printed. But see next commit.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

The function was only called with "0" as argument. Drop it.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This time I added -Wmissing-prototypes and fixed accordingly. Again, this
used to be part of -Wall and I'm disgusted by it not being so any more.

What does "all" mean, then?

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

I added -Wstrict-prototypes, that used to be included in -Wall settings
but is not.  Actually, I think it should be an error to not specify an
argument list by now.  If any, -traditional is there for old timers.

Fortunately no bug was exposed by the missing prototypes.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Adam Wujek authored 9 years ago and Grzegorz Daniluk committed 9 years ago

remove waiting state, make waiting flag instead

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Adam Wujek authored 10 years ago and Grzegorz Daniluk committed 9 years ago

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Adam Wujek authored 10 years ago and Grzegorz Daniluk committed 9 years ago

Needed since ppsi moved to shmem and removed cur_servo_state structure from
servo.

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Adam Wujek authored 10 years ago and Grzegorz Daniluk committed 9 years ago

Done as a part of work to move hal to shm in wrs.

Done in this commit:
--use wrpc_get_port_state instead of halexp_get_port_state
--make wrpc_get_port_state fill hal_port_state structure in the way how HAL
  fills shmem.
--update lib/net.c to use struct hal_port_state instead of hexp_port_state_t
--update monitor/monitor_ppsi.c to use struct hal_port_state instead of
  hexp_port_state_t
--update ppsi to get needed changes

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Miguel Jimenez Lopez authored 11 years ago and Grzegorz Daniluk committed 11 years ago

	- Add new command "refresh" to change update period of gui and stat
	- Delete "stat cont" command
	- Update "stat" command to work as older "stat cont" one
	- Update the wrc_main.c file to check if the log messages must be generated one time

Note: If you set period to 0, the log messages are only generated one time.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Now "meanPathDelay" is called "oneWayDelay", so the new commits
force a one-line change.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Aurelio Colosimo <aurelio@aureliocolosimo.it>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Aurelio Colosimo <aurelio@aureliocolosimo.it>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This adds the build choice about whether to use the older sockitowm or
the new "w1" implementation, which supports all three thermometers
but is still missing eeprom support (the API is defined, though, see
include/w1.h

This also adds a shell command, called "w1", which rescans the bus and
tries to read the temperature from all devices. In the example below
the third device is an eeprom, so it return an error for temperature
read-out.

   wrc# w1
   W1: 68000801dce56910
   W1: f70000001eda8242
   W1: 5f00000040e50143
   device 0: 68000801dce56910
   temp: 34.7500
   device 1: f70000001eda8242
   temp: 32.5000
   device 2: 5f00000040e50143
   temp: -32768.0000

The code is properly integrated in wrpc-sw, and the "first" thermometer is
used to build the MAC address of the device, like it used to be with
sockitowm.

The binary built with w1 is 3kB smaller than what is build with sockitowm.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Aurelio Colosimo authored 12 years ago and Alessandro Rubini committed 12 years ago

Signed-off-by: Aurelio Colosimo <aurelio@aureliocolosimo.it>

Aurelio Colosimo authored 12 years ago and Alessandro Rubini committed 12 years ago

Signed-off-by: Aurelio Colosimo <aurelio@aureliocolosimo.it>

Aurelio Colosimo authored 12 years ago and Alessandro Rubini committed 12 years ago

Signed-off-by: Aurelio Colosimo <aurelio@aureliocolosimo.it>

Aurelio Colosimo authored 12 years ago and Alessandro Rubini committed 12 years ago

This is a placeholder for ppsi, filled by later patches

Signed-off-by: Aurelio Colosimo <aurelio@aureliocolosimo.it>
Acked-by: Alessandro Rubini <rubini@gnudd.com>