This changes the pfilter rule-set, to make it ready for vlan addition.
Moreover, it removes the choice between three rule-sets and uses one
that works for everyone (we'll add the vlan option later on).

Moreover, we prepare for the option of peer-delay PTP and UDP-based PTP.

As a side effect, one Kconfig option is removed.

We know for sure that what goes to the "streamer" protocol
is re-checked, so the streamer can get some "everything else", exactly
like the 7S wr-nic (that sends to the host everything unused).

This is the current rule set:

     - everything tagged is dropped
     - CPU: arp broadcast, not unicast (i.e. requests only).
     - CPU: PTP ethtype. Any mac address.
     - CPU: ICMP unicast, not broadcast.
     - CPU: UDP (uni/multicast), ports  bootpc, ptp-event, ptp-general.
     - Etherbone (class 7): UDP (uni/multicast) and port 0xebd0
     - Other fabric (class 6): anything not Etherbone (inverted class 7 bit)

Thi...

The makefile included trace.h for everyone, which in turns included
wrc.h.  It's better to include wrc.h straight on (we can't rely on all
files including it, for example pp_printf does not).

Meanwhile, some redundant includes are removed, and some are added
(I prefer wrc.h to be explicitly listed in the files that use it,
even if the command line set in Makefile already prepends it).

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Otherwise, the first "make" builds tools before spitting the
error about an unconfigured system. I prefer to have the error alone.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This quiet=quiet_ has the effect of printing

  HOSTCC  scripts/kconfig/conf.o
  HOSTCC  scripts/kconfig/kxgettext.o
  SHIPPED scripts/kconfig/zconf.tab.c
  SHIPPED scripts/kconfig/lex.zconf.c
  SHIPPED scripts/kconfig/zconf.hash.c
  HOSTCC  scripts/kconfig/zconf.tab.o
  HOSTLD  scripts/kconfig/conf

instead of the full command lines. We could even use quite=silent_ to
have no output at all, but this would introduce a noticeable delay in
the build.

The aim of this change is making more visible the error "your wrpc is
not configured" at the first build. The full compilation of config
stuff makes the error less clear, and the initial error confuses
people (me included).

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This reverts commit 3a3c3806.

The previous line: every object depending on .config, was better.
We had the problem that a fresh clone was not building because of a
missing autoconf.h.

The depend rule was not working anyways, because it created an empty
.depend the first time over, due to the missing autoconf.h.  I admit I
don't know how to create a depend file after configuration: make
pretends to remake all its inclusions as the first step, so a rule
like ".depend: silentoldconfig" loops forever.

Actually, Etherbone is in gateware, and this option only enables Internet
Protocol in the software.  This fixes a long-standing misunderstanding.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Accessing data structures in the host to get target fields is broken:
we may have different data size or alignment, or whatever. The hack
of using "-m32" to be able to access lm32 fields from x86-64 is not
clean (we imply the i386 and target have the same size/alignment).
Even worse, not everybody has an x86-64 cross-compiler for i386.

Thus, we use OFFSET_OF in the target, with the lm32 cross compiler,
to build a binary table that is then accessed by the host.

In order to link the data structure in the host we use the assembler
instead of objcopy. With objcopy we'd need to spell out the bfd name
of the host, and we'd get horrible names like
   struct dump_info _binary_dump_info_host_bin_start[];

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This reverts commit 03062ea3.

The patch is wrong, because it duplicates

    9491e61b

 ppsi: pick new master and fix building accordingly

which does the "fixing" in a more elegant way. With both in history,
we now have

   ./ppsi/include/generated/autoconf.h:13:0: warning:
           "CONFIG_VLAN_ARRAY_SIZE" redefined
   generated/autoconf.h:14:0: note: this is the previous definition

Besides, the reverted commit was not even using new ppsi master (we
did it before this commit).

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Use the rules from the array we are passed in the object file.
We'll use the feature when enabling vlans: at that point we'll have
two sets to choose from, according to run-time configuration.

Using the build-time configuration avoids the hairy ifdef and saves
almost 1kB of binary size.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Simplify access to $CONFIG_RAMSIZE. Actually, the previous way
was not working for me, as my $SHELL is not bash.

The bug is uncovered by the next commit, because the "-s" argument
to genramvhd has always been wrong for me, but I didn't notice
(so maybe the "-s" argument has no effect? I can't tell at this point)

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

"act accordingly" means pre-including ppsi/...autoconf.h within
CFLAGS, or we miss CONFIG_MAX_VLANS_PER_PORT, used in defining the
ppsi local data structure.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

The function ptpd_netif_create_socket() still receives two arguments,
because it is being called by ppsi, and I'd better not change the API
in small steps in there.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

y

This time I added -Wmissing-prototypes and fixed accordingly. Again, this
used to be part of -Wall and I'm disgusted by it not being so any more.

What does "all" mean, then?

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

I added -Wstrict-prototypes, that used to be included in -Wall settings
but is not.  Actually, I think it should be an error to not specify an
argument list by now.  If any, -traditional is there for old timers.

Fortunately no bug was exposed by the missing prototypes.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Yesterday I was eventually fussed up by the need to "make clean" every
time. So here's a stupid depend rule, not perfect but better than
nothing.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Adam Wujek authored 9 years ago and Grzegorz Daniluk committed 9 years ago

Add checking stack overflow and detecting reset to wrs. Code common for wrpc
and wrs is placed in system_checks.c and .h. Work is based on following
commits in wrc_main.c:
1704a668 main: check for stack overflow
7836c39e

 Optionally detect reset and print a stack trace

Additionally:
--update Kconfig to have a possibility to select CHECK_RESET also for switch,
  not only for node as before
--and _endram to ram-wrs.ld

When "stack overflow" occurs then message is printed once every second.
When reset occours then LM32 will print stack trace and reset once more.
NOTE: I couldn't get spll to work after reset, for sure problem is in
      ad9516 init function, but not only there.

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Adam Wujek authored 9 years ago and Grzegorz Daniluk committed 9 years ago

--increase spll_stats structure version to 2
--add to spll_stats structure:
  - commit_id
  - build_date
  - build_time
  - start_cnt (to be used later for start counter)
--move declaration of spll_stats structure from wrs_main.c to revision.c
--pass git version and author at compile time to revision.c
--create revision.h with build_* externs
--update version reporting at cpu start
--update version command
--include section .stats in section .data for node

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Theodor-Adrian Stana authored 11 years ago and Grzegorz Daniluk committed 10 years ago

The flash-write tool is operational. The call to read status register
from flash-host is not working yet, and that is to be solved. In the
meantime, there are sleep functions inserted where we're supposed
to poll the status register.

Signed-off-by: Theodor Stana <t.stana@cern.ch>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Pietro Fezzardi authored 10 years ago and Alessandro Rubini committed 10 years ago

This adds 2.3kB to the GSI configuration, beause it enable ptpdump.
Earlier it was always forces off, due to wrong comparison of ram size.

Alessandro Rubini authored 11 years ago and Grzegorz Daniluk committed 10 years ago

This includes ppsi-v2014.07.

The new ppsi master is Kconfig-based, so our makefile must
make "wrpc_defconfig" in ppsi before building it.
Additionally, the link steps changed to the better in there, so we
don't link the "strange" $(PPSI)/proto-standard/libstd.a any more.

We may consider whether a local .config for ppsi should be
provided by this package instead of relying on its own choices;
not a big deal, though, as we maintain them at the same time.

Please note that any existent ppsi/.config is preserved, to allow
local tests. This should not have any impact on normal users.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

ram.ld must be rebuilt every time the configuration changes. It was
supposed to be like that, but it was not.

So, the older ram.ld was used when first building with a new config,
and only the second time the rule was used. This was exposed by
failuers in ./MAKEALL where each configuration is built only once.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This fixes the makefile to build either wrc.bin or rt_cpu.bin, using
the obj-y convention. At this point Kconfig can't select rt_cpu.bin,
and nothing changes in the ouput binary, in all configurations.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Etherbone won't fit with a full ppsi in the default RAM size for SPEC
cards. So this commit uses a ppsi hack to avoid internal ptpdump,
activating it when CONFIG_RAMSIZE is not 128kB and CONFIG_ETHERBONE is
set.

We should rather compare RAMSIZE with "< 131072", but neither gnu make
nor this version of Kconfig support numeric comparison.

This hack will soon disappera, as ppsi is gaining Kconfig support, so
wrpc-sw will be able to pass proper configuration. Also, 128kB will soon
be the default for SPEC images.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

These headers shadow system headers.
While they are necessary for building on the LM32, it breaks any
code that wants the other WR headers on a different architecture.

By moving these headers, we can pick whether to use them or not.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This is needed to build sdb-lib for the target, in case you rely on
the default value for CROSS_COMPILE instead of using the environment
variable.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

We don't want to call the real printf, which brings in the whole of
newlib, but it sometimes happen. So let's diagnose the problem
immediately rather than letting users wonder what is wrong with the
size.

Similarly, if building under ppsi, ensure we are not calling libgcc
division functions: any 64-bit division my be done with __div64_32
offered by ppsi/lib (copied from the kernel).

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

With this commit, when you select both the hardware and software uart,
ppsi diagnostics (controlled  by the "verbose" command) got to
the software uart, not to the hardware one. In this way you can run
the shell in a clean tty.

Unfortunately, frame dumps still reach the hardware uart, if frame
verbosity is greater than 1.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

We need to link ppsi/proto-standard/libstd.a explicitly, but we also
need a rule to generate it, or parallel compilation fails saying it
has no rule. The makefile depended on build order (my fault), as
building ppsi/ppsi.o, with its rule), also built libstd.a

BTW, this removes ppsi/arch-wrpc/libarch.a from the dependencies,
because it is already linked in making ppsi/ppsi.o (otoh the need for
an explicit mention of libstd.a can't easily be solved in ppsi
itself, so it remains here).

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

In recent ppsi code, proto-ext-whiterabbit is not replicating
proto-standard any more, but rather it offers hooks for the additional
code it needs.  Thus, we need to link the library for standard PTP as
well, to pick some of the states for the WR state machine.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>