Skip to content

W
White Rabbit Switch - Software
Commit 93f2411e authored by Maciej Lipinski's avatar Maciej Lipinski
Browse files
Options

[HAL] fixed port LEDs 

Two issues:
1) the update function of sync led had a bug
   (wrong structure updated)
2) the leds were not reseted when on link_down

Also, in the "old HAL", the wrmode LED was set
to SFP_LED_WRMODE_OFF, so I updated the code
accordingly.
parent 79e5027e
Hide whitespace changes
Inline Side-by-side
Showing with 8 additions and 3 deletions
userspace/wrsw_hal/hal_port_fsm.c
View file @ 93f2411e
......@@ -183,6 +183,11 @@ static int _hal_port_state_link_down(void *vpfg, int eventMsk, int isNewState) {
_reset_port(ps);
/* Init the rx state machine */
hal_port_rx_setup_init_fsm(ps);
/* Turn off both leds when detecting link down. The WRMODE led
might be overriden later by the rx_setup_state_fsm*/
led_set_wrmode(ps->hw_index,SFP_LED_WRMODE_OFF);
led_set_synched(ps->hw_index, 0);
}
/* if final state reached for tx setup state machine then
......@@ -342,9 +347,9 @@ static void _reset_port(struct hal_port_state * ps)
ps->tx_cal_pending = 0;
ps->rx_cal_pending = 0;
/* Set link/wrmode LEDs to other. Master/slave
/* Turn off link/wrmode LED. Master/slave
* color is set in the different place */
led_set_wrmode(ps->hw_index,SFP_LED_WRMODE_OTHER);
led_set_wrmode(ps->hw_index,SFP_LED_WRMODE_OFF);
/* turn off synced LED */
led_set_synched(ps->hw_index, 0);
......
userspace/wrsw_hal/hal_port_leds.c
View file @ 93f2411e
......@@ -95,7 +95,7 @@ void led_link_update(struct hal_port_state *ps) {
if (portIndex >= HAL_MAX_PORTS)
return;
_leds.sync_leds_map[portIndex] = value;
_leds.sync_leds_map_to_update[portIndex] = value;
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment