Two issues:
1) the update function of sync led had a bug
   (wrong structure updated)
2) the leds were not reseted when on link_down

Also, in the "old HAL", the wrmode LED was set
to SFP_LED_WRMODE_OFF, so I updated the code
accordingly.