SFP matching is done by in order:
-vendor name, part number, serial
-vendor name, part number
-part number

If .config's entry (i.e. serial) is not empty match will happen only with
specific serial.

Additionally:
-Change default defines in Kconfig
-Update user manual with matching info
-Remove entry from wrs-todo about matching SFP vendor

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Update dump_shmem accordingly.
Increment HAL_SHMEM_VERSION due to changes in shw_sfp_caldata structure.
Still missing matching based on vendor name and part number.
Update hal_shmem.h in ppsi

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Remove spaces from read SFP header
-vendor_name
-vendor_pn
-vendor_serial

Don't read SFP header twice at hal_port_insert_sfp in hal_port. Before header
was read first in function shw_sfp_read_verify_header, then indirectly by
shw_sfp_get_cal_data

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Alessandro Rubini authored 10 years ago and Adam Wujek committed 10 years ago

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Alessandro Rubini authored 10 years ago and Adam Wujek committed 10 years ago

delta_tx and delta_rx in the SFP information are differences from
the values in the "calibration" SFP model. Thus they are signed
not uint32_t.  Fortunately nobody used negative values so far.

I also renamed the fields, to ensure the compiler would find all uses.

The commit also syncs headers to ppsi, including the changes that
happened here but were irrelevant to there.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This replicates the bevaviour of previous code, unchanged. Only,
Kconfig is now used to specify the alpha for the pair of wavelengths
being used.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This commit uses dot-config (previous commit), in exactly the same way
as previous code. No change in behaviour is there, as confirmed by
looking at shared memory values.

However, the alpha value is not part of the SFP definition any more,
but it is part of the fiber type (later commits).  So it is currently
hardwired in the code, matching previous config values.

The data structures are slightly changed, so the version in shared memory
is increased too.  wrs_dump_shmem is updated at the same time
and ppsi is updated to get the new headers.

As a side effect, this uses calloc() instead of malloc(), and sets a
sensible (though unused) value in the "flags" field of the sfp data.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This is a completely automatic pass, before we start making order
in this library (note: there is a missing semicolon in pps_gen.c:82
but it will be fixed in a later commit -- the bug is in the macro
being called, so the missing semicolon is ok for the compiler).

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This commit makes no changes, as shown by "git diff -w" before
committing, but blank spaces at end-of-line make my editor scream
(because I'm pedanting in not pushing those to the kernel).

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

NOTE: libwr builds, but not other userspace apps

Grzegorz Daniluk authored 11 years ago and Alessandro Rubini committed 10 years ago

Requires modified HDL which uses single xwb_i2c_master to access all 3
I2C interfaces (MiniBackplane_I2C0, MiniBackplane_I2C1, Sensors_I2C).

Signed-off-by: Manohar Vanga <manohar.vanga@cern.ch>

Signed-off-by: Manohar Vanga <manohar.vanga@cern.ch>

Signed-off-by: Manohar Vanga <manohar.vanga@cern.ch>