wr_nic: invert return value of function mac_pton (endpoint.c)

In kernel this function returns 1/true on success! Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

wr_nic: invert return value of function mac_pton (endpoint.c)
In kernel this function returns 1/true on success! Signed-off-by: Adam Wujek <adam.wujek@cern.ch>
d0b3fc9c · Adam Wujek · Miguel Jimenez Lopez · ea930b0a · d0b3fc9c
Commit d0b3fc9c authored Oct 31, 2014 by Adam Wujek 💬 Committed by Miguel Jimenez Lopez Apr 04, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 6 deletions

endpoint.c kernel/wr_nic/endpoint.c +6 -6

No files found.
--- a/kernel/wr_nic/endpoint.c
+++ b/kernel/wr_nic/endpoint.c
@@ -29,21 +29,21 @@ static int mac_pton(const char *s, u8 *mac)

 	/* XX:XX:XX:XX:XX:XX */
 	if (strlen(s) < 3 * ETH_ALEN - 1)
-		 return -EINVAL;
+		return 0;

 	/* Don't dirty result unless string is valid MAC. */
 	for (i = 0; i < ETH_ALEN; i++) {
 		if (!strchr("0123456789abcdefABCDEF", s[i * 3]))
-			return -EINVAL;
+			return 0;
 		if (!strchr("0123456789abcdefABCDEF", s[i * 3 + 1]))
-			return -EINVAL;
+			return 0;
 		if (i != ETH_ALEN - 1 && s[i * 3 + 2] != ':')
-			return -EINVAL;
+			return 0;
 	}
 	for (i = 0; i < ETH_ALEN; i++) {
 		mac[i] = (hex_to_bin(s[i * 3]) << 4) | hex_to_bin(s[i * 3 + 1]);
 	}
-	return 0;
+	return 1;
 }

 /*
@@ -257,7 +257,7 @@ int wrn_endpoint_probe(struct net_device *dev)

 	if (is_zero_ether_addr(wraddr)) {
 		err = mac_pton(macaddr, wraddr);
-		if (err)
+		if (!err)
 			pr_err("wr_nic: probably invalid MAC address \"%s\".\n"
 			       "Use format XX:XX:XX:XX:XX:XX\n", macaddr);
 	}