general cleanup of wrong prototypes

I added -Wstrict-prototypes, that used to be included in -Wall settings
but is not.  Actually, I think it should be an error to not specify an
argument list by now.  If any, -traditional is there for old timers.

Fortunately no bug was exposed by the missing prototypes.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Makefile

@@ -61,9 +61,11 @@ include pp_printf/printf.mk
 include dev/dev.mk
 include softpll/softpll.mk
 
-# ppsi already has div64 (the same one), so only pick it if not using ppsi
+# ppsi already has div64 (the same one), so only pick it if not using ppsi.
 ifndef CONFIG_PPSI
-obj-y += pp_printf/div64.o
+  obj-y += pp_printf/div64.o
+  # unfortunately, we need a prototype there
+  cflags-y += -include include/wrc.h
 endif
 # And always complain if we pick the libgcc division: 64/32 = 32 is enough here.
 obj-y += check-error.o
@@ -74,7 +76,7 @@ obj-y += system_checks.o
 obj-$(CONFIG_WR_NODE) += sdb-lib/libsdbfs.a
 cflags-$(CONFIG_WR_NODE) += -Isdb-lib
 
-CFLAGS = $(CFLAGS_PLATFORM) $(cflags-y) -Wall \
+CFLAGS = $(CFLAGS_PLATFORM) $(cflags-y) -Wall -Wstrict-prototypes \
 	-ffunction-sections -fdata-sections -Os \
 	-include include/trace.h -ggdb
 

arch/lm32/irq.c

@@ -8,7 +8,7 @@
  */
 #include "irq.h"
 
-void disable_irq()
+void disable_irq(void)
 {
 	unsigned int ie, im;
 	unsigned int Mask = ~1;
@@ -25,7 +25,7 @@ void disable_irq()
 
 }
 
-void enable_irq()
+void enable_irq(void)
 {
 	unsigned int ie, im;
 	unsigned int Mask = 1;

dev/ad9516.c

@@ -68,7 +68,7 @@ struct ad9516_reg {
 
 static void *oc_spi_base;
 
-int oc_spi_init(void *base_addr)
+static int oc_spi_init(void *base_addr)
 {
 	oc_spi_base = base_addr;
 
@@ -76,7 +76,7 @@ int oc_spi_init(void *base_addr)
 	return 0;
 }
 
-int oc_spi_txrx(int ss, int nbits, uint32_t in, uint32_t *out)
+static int oc_spi_txrx(int ss, int nbits, uint32_t in, uint32_t *out)
 {
 	uint32_t rval;
 
@@ -129,14 +129,14 @@ static void ad9516_load_regset(const struct ad9516_reg *regs, int n_regs, int co
 }
 
 
-static void ad9516_wait_lock()
+static void ad9516_wait_lock(void)
 {
 	while ((ad9516_read_reg(0x1f) & 1) == 0);
 }
 
 #define SECONDARY_DIVIDER 0x100
 
-int ad9516_set_output_divider(int output, int ratio, int phase_offset)
+static int ad9516_set_output_divider(int output, int ratio, int phase_offset)
 {
 	uint8_t lcycles = (ratio/2) - 1;
 	uint8_t hcycles = (ratio - (ratio / 2)) - 1;
@@ -188,7 +188,7 @@ int ad9516_set_output_divider(int output, int ratio, int phase_offset)
 	return 0;
 }
 
-int ad9516_set_vco_divider(int ratio) /* Sets the VCO divider (2..6) or 0 to enable static output */
+static int ad9516_set_vco_divider(int ratio) /* Sets the VCO divider (2..6) or 0 to enable static output */
 {
 	if(ratio == 0)
 		ad9516_write_reg(0x1e0, 0x5); /* static mode */
@@ -198,7 +198,7 @@ int ad9516_set_vco_divider(int ratio) /* Sets the VCO divider (2..6) or 0 to ena
 	return 0;
 }
 
-void ad9516_sync_outputs()
+static void ad9516_sync_outputs(void)
 {
 	/* VCO divider: static mode */
 	ad9516_write_reg(0x1E0, 0x7);

dev/eeprom.c

@@ -14,6 +14,7 @@
 #include "storage.h"
 #include "board.h"
 #include "syscon.h"
+#include "onewire.h"
 
 /*
  * The SFP section is placed somewhere inside FMC EEPROM and it really does not

dev/ep_pfilter.c

@@ -98,12 +98,12 @@ static int code_pos;
 static uint64_t code_buf[32];
 
 /* begins assembling a new packet filter program */
-static void pfilter_new()
+static void pfilter_new(void)
 {
 	code_pos = 0;
 }
 
-static void check_size()
+static void check_size(void)
 {
 	if (code_pos == PFILTER_MAX_CODE_SIZE - 1) {
 		pfilter_dbg("microcode: code too big (max size: %d)\n",
@@ -144,7 +144,7 @@ static void pfilter_cmp(int offset, int value, int mask, pfilter_op_t op,
 	code_buf[code_pos++] = ir;
 }
 
-static void pfilter_nop()
+static void pfilter_nop(void)
 {
 	uint64_t ir;
 	check_size();
@@ -185,7 +185,7 @@ static void pfilter_logic3(int rd, int ra, pfilter_op_t op, int rb,
 }
 
 /* Terminates the microcode, loads it to the endpoint and enables the pfilter */
-static void pfilter_load()
+static void pfilter_load(void)
 {
 	int i;
 	code_buf[code_pos++] = (1ULL << 35);	// insert FIN instruction

dev/flash.c

@@ -16,7 +16,7 @@
 /*
  * Delay function - limit SPI clock speed to 10 MHz
  */
-static void delay()
+static void delay(void)
 {
 	int i;
 	for (i = 0; i < (int)(CPU_CLOCK/10000000); i++)

dev/i2c.c

@@ -13,7 +13,7 @@
 
 #define I2C_DELAY 300
 
-void mi2c_delay()
+void mi2c_delay(void)
 {
 	int i;
 	for (i = 0; i < I2C_DELAY; i++)

dev/minic.c

@@ -117,7 +117,7 @@ static uint8_t *minic_rx_memset(uint8_t * mem, uint8_t c, uint32_t size)
 	return (uint8_t *) src;
 }
 
-static void minic_new_rx_buffer()
+static void minic_new_rx_buffer(void)
 {
 	minic_writel(MINIC_REG_MCR, 0);
 	minic.rx_base = dma_rx_buf;
@@ -137,7 +137,7 @@ static void minic_rxbuf_free(uint32_t words)
 	minic_writel(MINIC_REG_RX_AVAIL, words);
 }
 
-static void minic_new_tx_buffer()
+static void minic_new_tx_buffer(void)
 {
 	minic.tx_base = dma_tx_buf;
 	minic.tx_size = MINIC_DMA_TX_BUF_SIZE >> 2;

dev/rxts_calibrator.c

@@ -117,7 +117,7 @@ static int cal_cur_phase;
    ptpnetif's check lock function when the PLL has already locked, to avoid
    complicating the API of ptp-noposix/ppsi. */
 
-void rxts_calibration_start()
+void rxts_calibration_start(void)
 {
 	cal_cur_phase = 0;
 	det_rising.prev_val = det_falling.prev_val = -1;

dev/sfp.c

@@ -15,7 +15,7 @@
 #include "i2c.h"
 #include "sfp.h"
 
-int sfp_present()
+int sfp_present(void)
 {
 	return !gpio_in(GPIO_SFP_DET);
 }

dev/uart-sw.c

@@ -27,7 +27,7 @@ void __attribute__((weak)) uart_init_hw(void)
 {}
 
 
-void uart_sw_write_byte(int b)
+static void uart_sw_write_byte(int b)
 {
 	int index;
 
@@ -50,7 +50,7 @@ int uart_sw_write_string(const char *s)
 	return s - t;
 }
 
-int uart_sw_read_byte()
+static int uart_sw_read_byte(void)
 {
 	int index;
 
@@ -68,6 +68,6 @@ void uart_write_byte(int b)
 	__attribute__((alias("uart_sw_write_byte"), weak));
 int uart_write_string(const char *s)
 	__attribute__((alias("uart_sw_write_string"), weak));
-int uart_read_byte()
+int uart_read_byte(void)
 	__attribute__((alias("uart_sw_read_byte"), weak));
 

dev/uart.c

@@ -46,12 +46,12 @@ int uart_write_string(const char *s)
 	return s - t;
 }
 
-static int uart_poll()
+static int uart_poll(void)
 {
 	return uart->SR & UART_SR_RX_RDY;
 }
 
-int uart_read_byte()
+int uart_read_byte(void)
 {
 	if (!uart_poll())
 		return -1;

include/board-wrc.h

@@ -29,8 +29,8 @@
 /* Number of auxillary clock channels - usually equal to the number of FMCs */
 #define NUM_AUX_CLOCKS 1
 
-int board_init();
-int board_update();
+int board_init(void);
+int board_update(void);
 
 /* spll parameter that are board-specific */
 #define BOARD_DIVIDE_DMTD_CLOCKS	1

include/endpoint.h

@@ -22,13 +22,13 @@ void get_mac_addr(uint8_t dev_addr[]);
 void set_mac_addr(uint8_t dev_addr[]);
 int ep_enable(int enabled, int autoneg);
 int ep_link_up(uint16_t * lpa);
-int ep_get_bitslide();
+int ep_get_bitslide(void);
 int ep_get_deltas(uint32_t * delta_tx, uint32_t * delta_rx);
 int ep_get_psval(int32_t * psval);
-int ep_cal_pattern_enable();
-int ep_cal_pattern_disable();
-int ep_timestamper_cal_pulse();
+int ep_cal_pattern_enable(void);
+int ep_cal_pattern_disable(void);
+int ep_timestamper_cal_pulse(void);
 
-void pfilter_init_default();
+void pfilter_init_default(void);
 
 #endif

include/i2c.h

@@ -9,7 +9,7 @@ void mi2c_stop(uint8_t i2cif);
 void mi2c_get_byte(uint8_t i2cif, unsigned char *data, uint8_t last);
 unsigned char mi2c_put_byte(uint8_t i2cif, unsigned char data);
 
-void mi2c_delay();
+void mi2c_delay(void);
 //void mi2c_scan(uint8_t i2cif);
 
 #endif

include/irq.h

 #ifndef __IRQ_H
 #define __IRQ_H
 
-static inline void clear_irq()
+static inline void clear_irq(void)
 {
 	unsigned int val = 1;
 	asm volatile ("wcsr ip, %0"::"r" (val));
 }
 
-void disable_irq();
-void enable_irq();
+void disable_irq(void);
+void enable_irq(void);
 
 #endif

include/minic.h

@@ -9,9 +9,9 @@
 
 #define WRPC_FID				0
 
-void minic_init();
-void minic_disable();
-int minic_poll_rx();
+void minic_init(void);
+void minic_disable(void);
+int minic_poll_rx(void);
 void minic_get_stats(int *tx_frames, int *rx_frames);
 
 int minic_rx_frame(uint8_t * hdr, uint8_t * payload, uint32_t buf_size,

include/ptpd_netif.h

@@ -94,7 +94,7 @@ typedef struct _wr_timestamp wr_timestamp_t;
 // - opens devices
 // - does necessary ioctls()
 // - initializes connection with the mighty HAL daemon
-int ptpd_netif_init();
+int ptpd_netif_init(void);
 
 // Creates UDP or Ethernet RAW socket (determined by sock_type) bound to bind_addr. If PTPD_FLAG_MULTICAST is set, the socket is
 // automatically added to multicast group. User can specify physical_port field to bind the socket to specific switch port only.
@@ -219,12 +219,12 @@ int ptpd_netif_get_ifName(char *ifname, int number);
  * HEXP_LOCK_STATUS_BUSY  	1
  * HEXP_EXTSRC_STATUS_NOSRC  	2
  */
-int ptpd_netif_extsrc_detection();
+int ptpd_netif_extsrc_detection(void);
 
 /* Timebase adjustment functions - the servo should not call the HAL directly */
 int ptpd_netif_adjust_counters(int64_t adjust_sec, int32_t adjust_nsec);
 int ptpd_netif_adjust_phase(int32_t phase_ps);
-int ptpd_netif_adjust_in_progress();
+int ptpd_netif_adjust_in_progress(void);
 void ptpd_netif_linearize_rx_timestamp(wr_timestamp_t * ts, int32_t dmtd_phase,
 				       int cntr_ahead, int transition_point,
 				       int clock_period);

include/rxts_calibrator.h

@@ -10,7 +10,7 @@
 #ifndef __RXTS_CALIBRATOR_H
 #define __RXTS_CALIBRATOR_H
 
-void rxts_calibration_start();
+void rxts_calibration_start(void);
 int rxts_calibration_update(int *t24p_value);
 int measure_t24p(uint32_t *value);
 int calib_t24p(int mode, uint32_t *value);

include/sfp.h

@@ -6,7 +6,7 @@
 #include <stdint.h>
 
 /* Returns 1 if there's a SFP transceiver inserted in the socket. */
-int sfp_present();
+int sfp_present(void);
 
 /* Reads the part ID of the SFP from its configuration EEPROM */
 int sfp_read_part_id(char *part_id);