Looked at part of the serializer.

git-svn-id: http://svn.ohwr.org/cern-fip/trunk/hdl/design@150 7f0067c9-7624-46c7-bd39-3fb5400c0213

Looked at part of the serializer.
git-svn-id: http://svn.ohwr.org/cern-fip/trunk/hdl/design@150 7f0067c9-7624-46c7-bd39-3fb5400c0213
d8d9d057 · serrano · 84a07903 · d8d9d057
Commit d8d9d057 authored Jan 26, 2011 by serrano
Hide whitespace changes
Inline Side-by-side

Showing with 15 additions and 0 deletions

javier.txt CodeReview_24Jan11/javier.txt +15 -0

No files found.
--- a/CodeReview_24Jan11/javier.txt
+++ b/CodeReview_24Jan11/javier.txt
@@ -18,6 +18,9 @@ active low (which in this particular case it is).
 If a file is not listed below it does not mean all is good, just that
 I did not have time to look at it ;)

+Question for Eva (did not have time to look): we know all inputs are
+well registered. Are all outputs registered as well?
+
 nanofip.vhd
 -----------

@@ -125,6 +128,18 @@ Line 90. Minor point. It should be "g_DEGLITCH_LGTH" instead of

 Line 103. Minor: it should be "WF_rx_tx_osc" instead of "WF_tx_rx_osc".

+wf_rx_deserializer.vhd (only looked at part of it)
+----------------------
+
+Line 240. I wonder if we should have an additional condition which
+takes this state machine to Idle, namely the wfip link being inactive,
+i.e. maintaining a constant level for a long (to be defined)
+time. This would ensure the state machine is always sitting in the
+Idle state before the beginning of a frame. With the current
+implementation, it might well be the case, but there are many
+scenarios to analyze and we risk forgetting something.
+
+
 wf_rx_tx_osc.vhd
 ----------------