Commit 85bdbb8a authored by Denia Bouhired-Ferrag's avatar Denia Bouhired-Ferrag

Adding review comments from v4 review

parent 2d08a26c
Javier
---------
- VME sys_reset line: is it guaranteed to be pulled up in the backplane?
If not, maybe a 4k7 pull-up in the board?
- Power supply for blocking output stages: the 27V is derived from the VME 12V supply. Any reason for that? It seems that the 12V is not the supply that can give the most power in ELMA crates. In fact, some ELMA catalogue I saw online says the 12V can supply 66W, while the 5V supply can give something like 200W. Has any thought been given to the scenario of a big crate full of pulse repeaters, in terms of the ability of the crate to cope with the power consumption? Sorry if this is a solved issue already. I looked to see if there is power consumption information online but could not find it. What is the typical and worst-case consumption in each of the voltage rails?
Erik
-----
SCHEMATICS
The designers name of Last Modified is not the one who last modified.
Schematics show V3-0 (apart from top one) instead of V4-0.
Copyright should be 2017?
CERN OHL version should be V1.2?
Get rid of the dots in schematics reference designators. It’s a setting in Altium (Tools->Schematics->Marking, disable it)
(found this setting as it was documented in Mattia’s review http://www.ohwr.org/projects/wrs-low-jitter/wiki/Schematics_review :-)
cbrev[0:3] inputs are pulled down by default. V4 is given as "0100".
-> pcbrev[3:0]
(“Pulled down by default” means what? Internal in FPGA, by the resistors mounted? On the V1-V3 boards?
How would you set other ‘executions’ (i.e. other components mounted) (V4-0 vs V4-1?)
Versions and executions are documented here: http://www.ohwr.org/projects/ed/wiki/Board_Layout
On the Dipswitches is only a note about a single switch:
“TTL/INV_TTL_N This is used to determine the level of the input trigger connector”
Add notes also about the PULSE_WIDTH_SEL and GF_EN signals.
Via http://www.ohwr.org/projects/conv-ttl-blo/settings -> Versions:
In Versions: EDA-02446 v4. Make it EDA-02446-V4-0 to have the same convention as the other versions.
Also add a description what are main changes.
Close the older versions so that they cannot be modified anymore.
Also HW versions are in the main project because of historical reasons? Do not change now, but usually should be in the –hw project.
PCB
Licence version should be V1.2?
On the Dipswitches nothing is mentioned for signal GF_EN.
Also marking not very clear and not on same height.
At B9 (bottom right). Missing silkscreen ‘Gnd’?
PTS
Is the PTS extended for checking the PCB revision number (correct assembly of components)?
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment