Signed-off-by: Federico Vaga <federico.vaga@gmail.com>
Acked-by: Alessandro Rubini <rubini@gnudd.com>

The bug: if a device probe() fails, ZIO register the real ZIO device
anyway
The issue: on device probe() channel-set, trigger, channels and buffer
are not ready

The patch: do probe after the _complete_ registration of the real
device. In this way, it is guaranteed that all components are ready.
More over, if the probe fail, the device can be easly removed.

Signed-off-by: Federico Vaga <federico.vaga@gmail.com>
Acked-by: Alessandro Rubini <rubini@gnudd.com>

At the moment, no known driver use these operations so we can "safely"
remove them from the framework.
We decide to remove init() and exit() because, in the current
implementation, they introduce more problems than they solve.

If you used these functions, we suggest you to move your init()
functions in the probe() function and your exit() functions before
deregister the device.

Signed-off-by: Federico Vaga <federico.vaga@gmail.com>
Acked-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Federico Vaga <federico.vaga@gmail.com>

Signed-off-by: Federico Vaga <federico.vaga@gmail.com>
Acked-by: Alessandro Rubini <rubini@gnudd.com>

Raise a build error if the last attribute's enumarator (e.g.
_ZIO_BUF_ATTR_STD_NUM) is greater than the maximum numer of standard
attributes ZIO_MAX_STD_ATTR

Signed-off-by: Federico Vaga <federico.vaga@gmail.com>
Acked-by: Alessandro Rubini <rubini@gnudd.com>

The 'version' attribute is a standard attribute. It is placed at
the last position of the standard attribute array. In this way, it is
easier to identify it in an hexdump stream because it is the last
standard attribute. At the moment the last index of standard attributes
array is 15, but in a far away future may change.

The aim of this attribute is to identify the version of an attribute set
of a ZIO object (device, trigger, buffer). During development the set
of attribute exported by a driver may change. This attribute must be
used to notify these changes to user-space programs.
The attribute is optional.

When used in a device, we suggest to place it at device level.

Signed-off-by: Federico Vaga <federico.vaga@gmail.com>
Acked-by: Alessandro Rubini <rubini@gnudd.com>

This change also the meaning of the attribute. It is not the number of
re-enable after the first arm/fire. It is the absolute number of shots
that the trigger must do.

Signed-off-by: Federico Vaga <federico.vaga@gmail.com>
Acked-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Federico Vaga <federico.vaga@gmail.com>
Acked-by: Alessandro Rubini <rubini@gnudd.com>

Fix memory lost in an error condition

Signed-off-by: Federico Vaga <federico.vaga@gmail.com>
Acked-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
Acked-by: Federico Vaga <federico.vaga@gmail.com>

Federico Vaga authored 12 years ago and Alessandro Rubini committed 12 years ago

Signed-off-by: Federico Vaga <federico.vaga@gmail.com>
Acked-by: Alessandro Rubini <rubini@gnudd.com>

Federico Vaga authored 12 years ago and Alessandro Rubini committed 12 years ago

Signed-off-by: Federico Vaga <federico.vaga@gmail.com>
Acked-by: Alessandro Rubini <rubini@gnudd.com>

Federico Vaga authored 12 years ago and Alessandro Rubini committed 12 years ago

During creation, ti_create_and_init accept cset as parameter. So the
trigger can use this operation in some way. So, we cannot set to null
ti_old->cset because the trigger can use it again

Signed-off-by: Federico Vaga <federico.vaga@gmail.com>
Acked-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
Acked-by: Federico Vaga <federico.vaga@gmail.com>

Since the trigger often runs at interrupt time, we need the
irqsave/irqrestore spinlock in the critical sections of buffers.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
Acked-by: Federico Vaga <federico.vaga@gmail.com>

Federico Vaga authored 12 years ago and Alessandro Rubini committed 12 years ago

Warning introduced by
    0994f8c7

 trigger-user: arm on push only of all channels are ready

Signed-off-by: Federico Vaga <federico.vaga@gmail.com>
Acked-by: Alessandro Rubini <rubini@gnudd.com>

Some of the information in there was old, and we should rather extract
the files in Documentaion/zio/ from the doc/zio-manual.txt .
Currently, just remove the old information.

Please, users, read material in doc/ instead (or the pdf on ohwr.org).

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
Acked-by: Federico Vaga <federico.vaga@gmail.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
Acked-by: Federico Vaga <federico.vaga@gmail.com>

Now that all buffers cannot fail at store_block() time, the file
operations can be simplified. This also fixes some misbehaviour in
corner cases.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
Acked-by: Federico Vaga <federico.vaga@gmail.com>

This is a fix for a design bug for this buffer. Actually, the
vmalloc buffer already is like this (and cannot be different).
This allows simplifying chardev.c and fix some corner cases that
are currently misbehaving.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
Acked-by: Federico Vaga <federico.vaga@gmail.com>

Signed-off-by: Federico Vaga <federico.vaga@gmail.com>
Acked-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
Acked-by: Federico Vaga <federico.vaga@gmail.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
Acked-by: Federico Vaga <federico.vaga@gmail.com>

Also, avoid dereferencing a NULL pointer in raw_io().

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
Acked-by: Federico Vaga <federico.vaga@gmail.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
Acked-by: Federico Vaga <federico.vaga@gmail.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
Acked-by: Federico Vaga <federico.vaga@gmail.com>

This also reorganizes generic_data_done to exploit symmetry between
input and output csets. Actually, we didn't update seq_num or the
timestamp for output, but now we have the current control in sysfs,
so we'd better update it every time.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
Acked-by: Federico Vaga <federico.vaga@gmail.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
Acked-by: Federico Vaga <federico.vaga@gmail.com>

Soft timestamping happens at zio_arm_trigger time. This removes
the various software timestamping in the individual trigger.
Moreover, arming is idempotent, so timestamp in the locked section,
only when the trigger is actually armed.

As usual, hardware can overwrite ti timestamps, so this software stamp
is only used for devices that have no better notion of time.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
Acked-by: Federico Vaga <federico.vaga@gmail.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
Acked-by: Federico Vaga <federico.vaga@gmail.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
Acked-by: Federico Vaga <federico.vaga@gmail.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
Acked-by: Federico Vaga <federico.vaga@gmail.com>

This help user-space programs which use libudev to rebuild the ZIO
device structure

Signed-off-by: Federico Vaga <federico.vaga@gmail.com>
Acked-by: Alessandro Rubini <rubini@gnudd.com>

This has no effect for ZIO users

Signed-off-by: Federico Vaga <federico.vaga@gmail.com>
Acked-by: Alessandro Rubini <rubini@gnudd.com>

address is a default ZIO binary attribute which return the channel
address structure zio_addr.

Signed-off-by: Federico Vaga <federico.vaga@gmail.com>
Acked-by: Alessandro Rubini <rubini@gnudd.com>

Alarms are raised by some events and are persistent (in sysfs
and in the control blocks) until they are cleared in sysfs.
Clearing is write-1-to-clear (i.e.: write 32 to clear bit 5).

Signed-off-by: Federico Vaga <federico.vaga@gmail.com>
Acked-by: Alessandro Rubini <rubini@gnudd.com>

The Linux kernel automatic updates the uevent attributes only if the
device has a bus or a class. When the Linux kernel updates the uevent it
automatically adds the DEVTYPE attribute if the device has a
device_type. In ZIO cset, channel, buffer and trigger have not a bus or
a class, but they have a different device_type. These attributes are used
to export the device_type to user-space and allow libudev to easy
inspect the ZIO device hierarchy.

Signed-off-by: Federico Vaga <federico.vaga@gmail.com>
Acked-by: Alessandro Rubini <rubini@gnudd.com>

Federico Vaga authored 12 years ago and Alessandro Rubini committed 12 years ago

This has no effect on ZIO users, but tries to make some
order in the file itself giving symbolic name to attribute
groups.

Signed-off-by: Federico Vaga <federico.vaga@gmail.com>
Acked-by: Alessandro Rubini <rubini@gnudd.com>

Conflicts:

	sysfs.c

Federico Vaga authored 12 years ago and Alessandro Rubini committed 12 years ago

The devname attribute returns the device name in /dev to gain access
to blocks.

Signed-off-by: Federico Vaga <federico.vaga@gmail.com>
Acked-by: Alessandro Rubini <rubini@gnudd.com>