- Jan 10, 2013
-
-
Alessandro Rubini authored
If the trigger is enabled on creation, it may fire before the cset is ready. This happened to me with "modprobe zio-zero trigger=irq". For this reason it must start disabled. Also, the create method MUST set ti->cset before activating the trigger, because the cset lock is needed to access the enable/disable flag. The commit adds a WARN() if the field is not set after creation, then it leaves it zeroed to ensure the system will crash, instead of having a subtle race. Also, add a pair of FIXME notes about the need to allow changing a trigger type while leaving the new one disabled. Signed-off-by:
Alessandro Rubini <rubini@gnudd.com> Acked-by:
Federico Vaga <federico.vaga@gmail.com>
-
Alessandro Rubini authored
This is a bug fix for overlooks in this same series of commits. I won't fix each lock when it is introduced before proposing for master, because it takes too much time. Signed-off-by:
-
Alessandro Rubini authored
Signed-off-by:
-
Alessandro Rubini authored
Signed-off-by:
-
Alessandro Rubini authored
Now we can have zero-size input blocks, as TDC is real. zio-dump should not complain when reading zero bytes, if zero were expected. Signed-off-by:
-
Alessandro Rubini authored
Signed-off-by:
-
Alessandro Rubini authored
This has two csets, with one channel each. The first returns timestamps in the data area, the second channel returns zero-sized blocks, with the timestamp in the control. Signed-off-by:
-
Alessandro Rubini authored
These changes allow the driver to work with a PCI interrupt, a role that was never used earlier. The commit fixes a warning on removal when if libgpio is not present in the host kernel; it also tries to request the shared interrrupt with various edge-trigger bits, until one succeeds. This allows to use both edges for owned GPIO interrupts and fall back to no specific requirement when used for a PCI interrupt. Signed-off-by:
-
Alessandro Rubini authored
This commit allows zero-size channels to exist. The feature is used for TDC and DTC (time to digital converters and the opposite). This simple change in the core allows to implement TDC drivers that only return the control (which includes a time stamp) and no data. For DTC to work we need some modification to chardev.c, which are not there yet. Signed-off-by:
-
Alessandro Rubini authored
Signed-off-by:
-
Alessandro Rubini authored
This is important now that we have self-timed devices: if any trigger parameter is changed (e.g., nsamples), we need to abort the armed trigger and rearm with new parameters. If the trigger is not armed when changing parameters, nothing happens like before. Signed-off-by:
-
Alessandro Rubini authored
Signed-off-by:
-
Alessandro Rubini authored
This small patch supports self-timed input csets (for example, a TDC) by ensuring the input trigger is always armed, waiting for the device. Signed-off-by:
-
Alessandro Rubini authored
Signed-off-by:
-
Alessandro Rubini authored
The flag is need so self-timed devices, like a TDC, can have their trigger continuously armed (see next commit). Signed-off-by:
-
Alessandro Rubini authored
The function used to be called __zio_internal_data_done, in heklpers.c. Being used once only, it was expanded inline by the compiler, so nothing changes for previous code. However, if a trigger needs to implement its own data_done method, it will most likely need to replicate this code, so it's better made avaiable directly to everybody. An alternative would be running this code every time, before or after calling t_op->data_done, but we'd better let each trigger choose the order of its own operations. Actually, there is one difference: the input active block is set to NULL after being stored to the current buffer, so the later implementation of stop_io (used in zio-irq-tdc.c) won't expose a bug. Signed-off-by:
-
Alessandro Rubini authored
This is the first step of a series of changes aimed at a cleaner and more flexible management of triggers, as well as a really transparent "user" trigger. This commit does the following: - zio_fire_trigger renamed to zio_arm_trigger: the trigger is actually armed by software, and then it fires by hardware. This distinction is especially important for the transparent trigger: when devices have internal timing, the software trigger must arm it immediately (as opposed to the dumb devices, where the software trigger really causes I/O to happen). - ZIO_TI_BUSY renamed to ZIO_TI_ARMED. Also, ZIO_TI_COMPLETING is removed. The new, simplified policy is like this: the trigger is armed by software (the trigger module), but completion is driven by hardware (the device module). There is no need for a COMPLETING flag, because the ARMED flag is only cleared after data_done is over for all channels in the cset. - the cset spinlock is used to protect all changes of the ti flags. - change_current_trigger completely revised and fixed to match new conventions. - trigger->abort now takes "ti" instead of "cset" as argument; it is more natural do do so, and no current trigger implements abort so no harm is done. - the trigger->abort and trigger->change_status methods are now always called while holding the cset spinlock. ZIO core calls abort when changing the current trigger type, to ensure no pending blocks are there. - zio_trigger_abort is renamed to zio_trigger_abort_disable, with an additional argument to state whether the trigger must be atomically disabled after the abort is over. This avoids a race condition on trigger removal. It returns the previous "disabled" bit, to be used when changing a buffer type while preserving trigger status. - minor unrelated improvements in error management in objects.c. - documentation update to match the new locking, and a few typos fixed. Signed-off-by:
-
- Jan 08, 2013
-
-
Alessandro Rubini authored
The merge-data attribute tells the buffer to try a merge of a newly-stored block with the previous one. When this is possible, the buffer updates the previous block (nsamples, datalen) and releases the new control immediately. This allows saving some memory without breaking the ZIO data model. The feature only makes sense for input, but there is no policy in place to enforce that. When user space reads this new block, it will get attributes (and timestamp) for the first data items, but all available items are returned in this bigger block. Signed-off-by:
-
Signed-off-by:
-
On load nsamples is 0 and this is wrong. It must be initialized with the value in ti->nsamples. Otherwise if you read the current_control on sturtup you will read 0 instead of the real value Signed-off-by:
-
- Dec 01, 2012
-
-
This patch fixes a few typos in the zio manual. Signed-off-by:Michael Auchter <michael.auchter@gmail.com>
-
- Nov 30, 2012
-
-
Alessandro Rubini authored
Signed-off-by:
-
Alessandro Rubini authored
Signed-off-by:
-
Alessandro Rubini authored
Signed-off-by:
-
Signed-off-by:
-
Signed-off-by:
-
- Nov 29, 2012
-
-
Alessandro Rubini authored
Signed-off-by:
-
Alessandro Rubini authored
Signed-off-by:
-
Alessandro Rubini authored
Signed-off-by:
-
Alessandro Rubini authored
pdftex has the very bad habit of picking png first, so we can't have png images or the pdf version will be horrible. Thus, let's use gif for the html (which is not picked by pdftex) and a .pdf generated by our encapsulated postscript sources. This adds the needed makefile and removes the previous pdf images, which are regenerated in the next commit. We are also adding new images where, including the logo used in the cover. Signed-off-by:
-
Alessandro Rubini authored
Parts are still to be written, though. Signed-off-by:
-
- Nov 26, 2012
-
-
Alessandro Rubini authored
Signed-off-by:
-
- Nov 25, 2012
-
-
Alessandro Rubini authored
Signed-off-by:
-
Alessandro Rubini authored
Signed-off-by:
-
Alessandro Rubini authored
Signed-off-by:
-
Alessandro Rubini authored
While the binary control file in sysfs is a neat feature, the interface to binary attributes was different before 2.6.35. This allows compiling with no warnings (and no crashes if the feature is used) by just disabling the attribute at compile time. Signed-off-by:
-
Alessandro Rubini authored
Signed-off-by:
-
Alessandro Rubini authored
Signed-off-by:
-
- Nov 24, 2012
-
-
Alessandro Rubini authored
-
Alessandro Rubini authored
We are getting rid of the "zio-" prefix in all file names. The prefix is needed module names (so all single-file devices triggers and buffers) but not in component files. This simplifies stuff a little for our command lines and tab completion. Signed-off-by:
-
