SET_HI32(variable, highhalf) was meant to prevent warnings and
unneeded code to get the best of 32 and 64 bits. But I had a bug
in 64-bit mode. This is the trivial fix.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

While building for a 64-bit host I found a few warnings in format strings.
One is corrected by using "%zi", and other ones are about resources.
Unfortunately %pR was added in 2.6.32, so to avoid introducing backporting
issues to our 2.6.24 cast the argument instead.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This includes a new version of the submodule and fixes the code
to match the new set of fields in the fmc structure. The biggest change
is in the i2c address, that is now hosted in the fmc structure (this
changes the spec-i2c file).

Also, use new fmc_reprogram().  The function allows to centralize
dumping the eeprom and the sdb tree, so the bus framework dumps or
not, and can be changed at run time.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

commit "9d4d08e5

kernel: correct warning for uninitialized variable"
introduced a bug, so the process was not properly awoken. The
commit is reported to be by Benoit, but I edited it and introduced
this bug which was missing in his submission.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Juan David Gonzalez Cobas authored 12 years ago and Alessandro Rubini committed 12 years ago

Forgot to deallocate the fmc_device allocated in spec_fmc_create.

Signed-off-by: Juan David Gonzalez Cobas <dcobas@cern.ch>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This patch adds a script "check-fmc-bus" that returns the pathname of
the fmc-bus kernel driver, either under this directory or under
../fmc-bus .  The former applies when fmc-bus is a submodule of this
package, the latter applies when we both are submodules of another
package.

The final aim is helping the naive user, who just wants to build it
all in a single step -- both if building this package or another
package that depends on both fmc-bus and this one.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

These bits were intruced in Linux-3.3, so don't refer to them.
Rather, err out on all unimplemented bits.  This is a different
patch from what David suggested.

Reported-by: Juan David Gonzalez Cobas <dcobas@cern.ch>
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Federico Vaga authored 12 years ago and Alessandro Rubini committed 12 years ago

Signed-off-by: Federico Vaga <federico.vaga@gmail.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This is not increasing the version number, because I plan to merge
before splitting off the fmc project.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

The code was checking the first LM32 instruction, but it used wrong
endianness.

This fixes the check, but the fix uncovered a bug: the "wrc=1"
parameter was only loading the first card. This fixes the bug
as well but not overwriting the user-provided parameter.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

When handling the interrupt, mask the pending bits with the not-empty
mask, otherwise an unexpected trigger-ready status may overflow the
for loop and eventually oops to panic.

Meanwhile, use a symbolic name for the mask and be more aggressive in
disabling (disable all bits: ho harm done for unimplemented interrupt
sources)

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Tomasz Wlostowski authored 12 years ago and Alessandro Rubini committed 12 years ago

This is not really a problem if we have edge-triggered interrupts as
input to the Gennum, but will lock the computer on unload when
experimenting with level-triggered interrupts.

We haven't been able to run Message Signalled Interrupt
reliably, for a quirck in the Gennum chip and the kernel
insisting to configure it according to the standard. So this
adds "use_msi" as a module parameter, disabled by default.
See documentation for details.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>