Signed-nof -by: Federico Vaga <federico.vaga@cern.ch>

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

With some kernel configuration the previous locking policy can
generate a deadlock on the spec->irq_lock spinlock.

For example, this will happen sistematically if the option
CONFIG_DEBUG_SHIRQ_FIXME is enabled. In this case, the handler
is called immediatly an it is not a separeted thread.

This patch move out from the locking section what doesn't need
protection and is 'cause' of the deadlock.

The deadlock was introduced with patch d4bbcc73 by using a large
locking section. In realty the PCI request_irq is protected
anyway thanks to the proctection of the variable 'first_time' and
the 'spec_vic_irq_request' function.

[more explaination about patch d4bbcc73

]
The purpose of that patch was to protect the initialization of
the first VIC handler and the release of the last one. It was
happening that while we are releasing the last VIC handler,
some one was registering a new one but the spec->vic is still there.
The result was that sometimes the PCI handler was removed
(last VIC handler) but not re-requested for the incoming request.

Signen-off-by: Federico Vaga <federico.vaga@cern.ch>

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

Sometimes (expecially in cross-compilation context) t is necessary to use
different environments. Instead of complicate this makefile, include
an external one with user code.

Create a local file named Makefile.specific, and write here your code.
Bear in mind that Makefile.specific will run before the Makefile.

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

    Note by Federico Vaga <federico.vaga@cern.ch>
        This is not exactly the same set of patches from
        garcialasheras <javier@garcialasheras.com>. I did few modification
        in order to:

        - do not introduce new dependecies. Vendor and Device ID are constant
          for life, so we can safely write them two times and avoid a file
          dependencies between kernel and userspace code.

        - squash FIX patches in 1d8bb157. There were consecutive patches where
          the FIX patch just fix the previous patch, so squash them. This will
          produce an useful git-blame and bit-bisect

        - una patch for each behavioral modification

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

Before this patch, on spec_check_id() error spec_scan() returns that it
found a SPEC, but it is not true.

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Protecting the handlers' vector is not enough. Managing the interrupts
involves other tasks that must be serialized. Mainly to handle the first
request and the last free of a VIC handler.

The VIC internal locking (vec_lock) is not useful anymore, but I do not
remove it because theoretically the VIC should be an independent bunch of
code.

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

When possible, avoid statement-scope variable for a better maintanability
of the code.

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

If there are no reasons for a *_free() function to return an error, change
the return type to void

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

The spec->irq_lock is a SPEC spinlock, but we must protect VIC variables.
In order to make the VIC code independent, use a dedicated VIC spinlock

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

Make the VIC code indipendently as much as possible

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

Use the specular name: we used init, we should use exit

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

On spec driver remove, do not clean-up VIC stuff. The VIC should be cleaned
by the mezzanine driver when it release all its handlers (see patch f7ee35460).
Just leave a reminder for driver developer when something goes wrong.

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

Interrupt resources are not properly released. Mainly two problems:

  1. on IRQ free the driver was using the IRQ number instead of the the
     component base address. So, the component IRQ handlers were never
     released

  2. on IRQ free, supposing that the first problem was not there, when
     all component's IRQ handlers were released the PCI IRQ handler (VIC
     dispatcher) should have released, but it was not. In consequence of this
     even if the driver was removed an interrupt can be handled by a
     ghost handler.

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>
Acked-by: Alessandro Rubini <rubini@gnudd.com>

The main reason to introduce this EXTRACFLAGS variable is to allow people
to cross compile on x86 architectures over 32bits and 64bits

    make EXTRACFLAGS="-m32"
    make EXTRACFLAGS="-m64"

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>
Acked-by: Alessandro Rubini <rubini@gnudd.com>

The Kbuild writesin 'src' the correct path to the source code automatically.
This avoid us to explicitly write 'M' variable

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>
Acked-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>
Acked-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Benoit Rat authored 11 years ago and Alessandro Rubini committed 11 years ago

* D/d,0,1 modes can not be used by the first channel (ch0)
* C/c mode is only useful for the last channel (ch4)

* wr-pps can not be used for channel 0

Benoit Rat authored 11 years ago and Alessandro Rubini committed 11 years ago

This also updates the links to binaries in the documentation.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

- Remove only for write in #72557df7
- NetworkManger (Unbuntu LTS 12.04) insists on accessing to the phy
when it is used from LM32 and flood the dmesg so we remove the warning.