Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Use _ABS in Makefiles wherever possible.

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

FMC_BUS_ABS is passed to Kbuild, which uses different current directory.
It is not trivial to handle FMC_BUS to be absolute or relative path.

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

files wr_nic/.*.o.cmd were not removed

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Include parent_common.mk from up directory. Which may contain various
environment definitions such compiler, linker, etc. If such file is not
present it will not affect build.

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

--export FMC_DRV
--correct passing GIT_VERSION

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

Signed-off-by: Adam Wujek <adam.wujek@cern.ch>

We were using vmalloc() assunign that its library was already included by some
other libraries. Today, this is not the case anymore, so we must include it

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

Mainly for compatibility (simplification) with the CERN super module.
Insted of using a script to guess which fmc-bus define, assume always
that parent project define the FMC_BUS to use.

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

For the time being you must write the bitstream in a single write. For
example:

    dd if=/home/fvaga/spec-fmc-adc-v4.0.bin of=/dev/spec-0700 obs=5000000

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

Since kernel 3.18 the gpiochip_remove function return void and not an
error code as before. In case the gpiochip is removed while there is a
requested gpio, the kernel will print an error message.

By applying this patch without any control on the kernel version we are
going to loose the error message in case of trouble with old kernels

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

There should not be any side effect on resetting the FGPA every time
we program it. Confirmed by Tomasz Wlostowski <tomasz.wlostowski@cern.ch>

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

Signed-nof -by: Federico Vaga <federico.vaga@cern.ch>

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

With some kernel configuration the previous locking policy can
generate a deadlock on the spec->irq_lock spinlock.

For example, this will happen sistematically if the option
CONFIG_DEBUG_SHIRQ_FIXME is enabled. In this case, the handler
is called immediatly an it is not a separeted thread.

This patch move out from the locking section what doesn't need
protection and is 'cause' of the deadlock.

The deadlock was introduced with patch d4bbcc73 by using a large
locking section. In realty the PCI request_irq is protected
anyway thanks to the proctection of the variable 'first_time' and
the 'spec_vic_irq_request' function.

[more explaination about patch d4bbcc73

]
The purpose of that patch was to protect the initialization of
the first VIC handler and the release of the last one. It was
happening that while we are releasing the last VIC handler,
some one was registering a new one but the spec->vic is still there.
The result was that sometimes the PCI handler was removed
(last VIC handler) but not re-requested for the incoming request.

Signen-off-by: Federico Vaga <federico.vaga@cern.ch>

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Protecting the handlers' vector is not enough. Managing the interrupts
involves other tasks that must be serialized. Mainly to handle the first
request and the last free of a VIC handler.

The VIC internal locking (vec_lock) is not useful anymore, but I do not
remove it because theoretically the VIC should be an independent bunch of
code.

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

When possible, avoid statement-scope variable for a better maintanability
of the code.

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

If there are no reasons for a *_free() function to return an error, change
the return type to void

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

The spec->irq_lock is a SPEC spinlock, but we must protect VIC variables.
In order to make the VIC code independent, use a dedicated VIC spinlock

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

Make the VIC code indipendently as much as possible

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

Use the specular name: we used init, we should use exit

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

On spec driver remove, do not clean-up VIC stuff. The VIC should be cleaned
by the mezzanine driver when it release all its handlers (see patch f7ee35460).
Just leave a reminder for driver developer when something goes wrong.

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

Interrupt resources are not properly released. Mainly two problems:

  1. on IRQ free the driver was using the IRQ number instead of the the
     component base address. So, the component IRQ handlers were never
     released

  2. on IRQ free, supposing that the first problem was not there, when
     all component's IRQ handlers were released the PCI IRQ handler (VIC
     dispatcher) should have released, but it was not. In consequence of this
     even if the driver was removed an interrupt can be handled by a
     ghost handler.

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

The Kbuild writesin 'src' the correct path to the source code automatically.
This avoid us to explicitly write 'M' variable

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>
Acked-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>
Acked-by: Alessandro Rubini <rubini@gnudd.com>

Benoit Rat authored 11 years ago and Alessandro Rubini committed 11 years ago

This also updates the links to binaries in the documentation.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

- Remove only for write in #72557df7
- NetworkManger (Unbuntu LTS 12.04) insists on accessing to the phy
when it is used from LM32 and flood the dmesg so we remove the warning.

This also documents how to write the eeprom, using the new writable
file in sysfs.  A working image for the eeprom is included, for people
with devices that were not programmed by the manufacturer.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Theodor-Adrian Stana authored 11 years ago and Alessandro Rubini committed 11 years ago

This is needed so the gennum core (as opposed to the gennum chip)
can access the SPI flash from the newly-programmed fpga image.
With this gpio setting, both the lm32 from inside the fpga
and the host computer can read and write the flash device.

Signed-off-by: Theodor Stana <t.stana@cern.ch>
Acked-by: Alessandro Rubini <rubini@gnudd.com>

The device is master-enabled at boot time, but the disable_device()
at remove time clears it. pci_enable_device() doesn't re-enable, so
we need to also pci_set_master().

Otherwise DMA works at first load, and the machine freezes at second load.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Juan David González Cobas authored 11 years ago and Alessandro Rubini committed 11 years ago

For traceability purposes, we include commit descriptions
as MODULE_VERSION information in drivers that are deployed
in CERN control system.

Ideally, the commit description should be added to all the
binary blobs installed, but the kernel module is critical
in this connection, as it is crucial to trace back quickly
the whereabouts of installed .ko sources.