Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
S
spec-sw
Manage
Activity
Members
Code
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Analyze
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
This is an archived project. Repository and other project resources are read-only.
fmc-projects
spec
spec-sw
Commits
7c47276e
There was an error fetching the commit references. Please try again later.
Commit
7c47276e
authored
12 years ago
by
Alessandro Rubini
Browse files
Options
Downloads
Patches
Plain Diff
fmc: read/writel can be null if base is provided
parent
d0b05c4a
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
doc/fmc-bus.in
+5
-5
5 additions, 5 deletions
doc/fmc-bus.in
kernel/spec-fmc.c
+1
-1
1 addition, 1 deletion
kernel/spec-fmc.c
with
6 additions
and
6 deletions
doc/fmc-bus.in
+
5
−
5
View file @
7c47276e
...
...
@@ -202,11 +202,11 @@ The individual methods perform the following tasks:
These functions access FPGA registers by whatever means the
carrier offers. They are not expected to fail, as most of the time
they will just make a memory access to the host bus.
Whil
e
ca
lling a function is slow
er th
an making direct access with macros,
flexibility requires this approach. Drivers may use the @code
{
base
}
pointer at their own risk, or maybe later specifications will mand
at
e
@code
{
base
}
to be equivalent to @i
{
readl
}
/@i
{
writel
}
if not
NULL.
they will just make a memory access to the host bus.
If th
e
ca
rrier provided a @i
{
base
}
point
er
,
th
e driver may use direct
access through it instead. For this reason the header offers
the inline functions @i
{
fmc
_
readl
}
and @i
{
fmc
_
writel
}
th
at
access @i
{
base
}
if respective method is
NULL.
For Etherbone, or other non-local carriers,
error-management is still to be defined.
...
...
This diff is collapsed.
Click to expand it.
kernel/spec-fmc.c
+
1
−
1
View file @
7c47276e
...
...
@@ -73,7 +73,7 @@ static int spec_irq_free(struct fmc_device *fmc)
}
static
struct
fmc_operations
spec_fmc_operations
=
{
/*
FIXME:
readl/writel */
/*
no
readl/writel
because we have the base pointer
*/
/* FIXME: reprogram */
.
irq_request
=
spec_irq_request
,
.
irq_ack
=
spec_irq_ack
,
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment