Skip to content
Snippets Groups Projects
Commit 7c47276e authored by Alessandro Rubini's avatar Alessandro Rubini
Browse files

fmc: read/writel can be null if base is provided

parent d0b05c4a
No related merge requests found
......@@ -202,11 +202,11 @@ The individual methods perform the following tasks:
These functions access FPGA registers by whatever means the
carrier offers. They are not expected to fail, as most of the time
they will just make a memory access to the host bus. While
calling a function is slower than making direct access with macros,
flexibility requires this approach. Drivers may use the @code{base}
pointer at their own risk, or maybe later specifications will mandate
@code{base} to be equivalent to @i{readl}/@i{writel} if not NULL.
they will just make a memory access to the host bus. If the
carrier provided a @i{base} pointer, the driver may use direct
access through it instead. For this reason the header offers
the inline functions @i{fmc_readl} and @i{fmc_writel} that
access @i{base} if respective method is NULL.
For Etherbone, or other non-local carriers,
error-management is still to be defined.
......
......@@ -73,7 +73,7 @@ static int spec_irq_free(struct fmc_device *fmc)
}
static struct fmc_operations spec_fmc_operations = {
/* FIXME: readl/writel */
/* no readl/writel because we have the base pointer */
/* FIXME: reprogram */
.irq_request = spec_irq_request,
.irq_ack = spec_irq_ack,
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment