Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
F
fmc-tdc-1ns-5cha-gw
Manage
Activity
Members
Code
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Analyze
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
This is an archived project. Repository and other project resources are read-only.
fmc-projects
fmc-tdc
fmc-tdc-1ns-5cha-gw
Commits
cd6e955a
Commit
cd6e955a
authored
13 years ago
by
serrano
Browse files
Options
Downloads
Patches
Plain Diff
One more file reviewed.
git-svn-id:
http://svn.ohwr.org/fmc-tdc@68
85dfdc96-de2c-444c-878d-45b388be74a9
parent
3f142deb
Branches
Branches containing commit
Tags
Tags containing commit
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
hdl/spec/src/code_review_08-11-2011/javier.txt
+7
-0
7 additions, 0 deletions
hdl/spec/src/code_review_08-11-2011/javier.txt
with
7 additions
and
0 deletions
hdl/spec/src/code_review_08-11-2011/javier.txt
+
7
−
0
View file @
cd6e955a
...
...
@@ -46,3 +46,10 @@ in its name.
Line 571. cs will not use an IOB FF because it is read in line
366. Please check all other cases when this can happen.
one_hz_gen.vhd
==============
Line 153. Similar comments on metastability as before. Also, the
assumption on the clock frequency of s_acam_refclk is very strong and
might be in trouble if sampling happens close to the edges and the
signals are a bit jittery. Why is this "frequency test" needed?
This diff is collapsed.
Click to expand it.
Preview
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment