kernel/wr-nic: Remove annoying warning message asking for the phy

NetworkManager tries to access the phy, so this WARN_ON is pretty common if the daemon is running. Now we know who is misbehaving, and the driver can keep silent (disclaimer: this opinionated message is by Alessandro :)

kernel/wr-nic: Remove annoying warning message asking for the phy
NetworkManager tries to access the phy, so this WARN_ON is pretty common if the daemon is running. Now we know who is misbehaving, and the driver can keep silent (disclaimer: this opinionated message is by Alessandro :)
0fade96a · Benoit Rat · Alessandro Rubini · 10c2756c · 0fade96a
Commit 0fade96a authored May 02, 2013 by Benoit Rat Committed by Alessandro Rubini Dec 04, 2014
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 1 deletion

endpoint.c kernel/wr_nic/endpoint.c +6 -1

No files found.
--- a/kernel/wr_nic/endpoint.c
+++ b/kernel/wr_nic/endpoint.c
@@ -74,7 +74,12 @@ void wrn_phy_write(struct net_device *dev, int phy_id, int location,
 	struct wrn_ep *ep = netdev_priv(dev);

 	if (WR_IS_NODE) {
-		WARN_ON(1); /* SPEC: no access */
+		/*
+		 * We cannot access the phy from Linux, because the phy
+		 * is managed by the lm32 core. However, network manager
+		 * insists on doing that, so we'd better not warn about it
+		 */
+		//WARN_ON(1); /* SPEC: no access */
 		return;
 	}