Skip to content

Z
ZIO
Switch branch/tag
  1. 10 Jan, 2013 3 commits
    • Alessandro Rubini's avatar
      zio.h and docs: introduce ZIO_CSET_SELF_TIMED · 23236075
      Alessandro Rubini authored 
      The flag is need so self-timed devices, like a TDC, can have their
trigger continuously armed (see next commit).
Signed-off-by: Alessandro Rubini's avatarAlessandro Rubini <rubini@gnudd.com>
Acked-by: 's avatarFederico Vaga <federico.vaga@gmail.com>
      23236075
    • Alessandro Rubini's avatar
      zio-trigger.h: offer zio_generic_data_done() as inline function · 90c6f046
      Alessandro Rubini authored 
      The function used to be called __zio_internal_data_done, in
heklpers.c.  Being used once only, it was expanded inline by the
compiler, so nothing changes for previous code.

However, if a trigger needs to implement its own data_done method, it
will most likely need to replicate this code, so it's better made
avaiable directly to everybody.  An alternative would be running this
code every time, before or after calling t_op->data_done, but we'd
better let each trigger choose the order of its own operations.

Actually, there is one difference: the input active block is set to NULL
after being stored to the current buffer, so the later implementation
of stop_io (used in zio-irq-tdc.c) won't expose a bug.
Signed-off-by: Alessandro Rubini's avatarAlessandro Rubini <rubini@gnudd.com>
Acked-by: 's avatarFederico Vaga <federico.vaga@gmail.com>
      90c6f046
    • Alessandro Rubini's avatar
      core: change some internals for triggers · a496ca04
      Alessandro Rubini authored 
      This is the first step of a series of changes aimed at a cleaner and
more flexible management of triggers, as well as a really transparent
"user" trigger.

This commit does the following:

- zio_fire_trigger renamed to zio_arm_trigger: the trigger is
actually armed by software, and then it fires by hardware. This
distinction is especially important for the transparent trigger: when
devices have internal timing, the software trigger must arm it
immediately (as opposed to the dumb devices, where the software trigger
really causes I/O to happen).

- ZIO_TI_BUSY renamed to ZIO_TI_ARMED. Also, ZIO_TI_COMPLETING is
removed. The new, simplified policy is like this: the trigger is armed
by software (the trigger module), but completion is driven by hardware
(the device module).  There is no need for a COMPLETING flag, because
the ARMED flag is only cleared after data_done is over for all channels
in the cset.

- the cset spinlock is used to protect all changes of the ti flags.

- change_current_trigger completely revised and fixed to match new
conventions.

- trigger->abort now takes "ti" instead of "cset" as argument; it is
more natural do do so, and no current trigger implements abort so no
harm is done.

- the trigger->abort and trigger->change_status methods are now
always called while holding the cset spinlock. ZIO core calls abort
when changing the current trigger type, to ensure no pending blocks
are there.

- zio_trigger_abort is renamed to zio_trigger_abort_disable, with
an additional argument to state whether the trigger must be atomically
disabled after the abort is over. This avoids a race condition on
trigger removal. It returns the previous "disabled" bit, to be used
when changing a buffer type while preserving trigger status.

- minor unrelated improvements in error management in objects.c.

- documentation update to match the new locking, and a few typos fixed.
Signed-off-by: Alessandro Rubini's avatarAlessandro Rubini <rubini@gnudd.com>
Acked-by: 's avatarFederico Vaga <federico.vaga@gmail.com>
      a496ca04
  3. 08 Jan, 2013 3 commits
  5. 01 Dec, 2012 1 commit
  7. 30 Nov, 2012 5 commits
  9. 29 Nov, 2012 5 commits
  11. 26 Nov, 2012 1 commit
  13. 25 Nov, 2012 6 commits
  15. 24 Nov, 2012 9 commits
  17. 15 Nov, 2012 3 commits
  19. 11 Nov, 2012 2 commits
  21. 09 Nov, 2012 2 commits