Skip to content

W
White Rabbit Trigger Distribution
Commit d7de6cf2 authored by Dimitris Lampridis's avatar Dimitris Lampridis
Browse files
Options

[sw] cleanup all leftover FIXME/TODOs

parent ccf58c66
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 25 deletions
software/firmware/adc/wrtd-adcin.c
View file @ d7de6cf2
...@@ -14,7 +14,6 @@ ...@@ -14,7 +14,6 @@
struct wrtd_adcin_dev { struct wrtd_adcin_dev {
uint32_t io_addr; uint32_t io_addr;
/* FIXME: base channel (to create the event id). */
}; };
static inline void adcin_writel(const struct wrtd_adcin_dev *dev, static inline void adcin_writel(const struct wrtd_adcin_dev *dev,
...@@ -55,10 +54,6 @@ static inline int adcin_wr_sync_timeout(void) ...@@ -55,10 +54,6 @@ static inline int adcin_wr_sync_timeout(void)
/** /**
* Handles input timestamps from all ADC channels. * Handles input timestamps from all ADC channels.
*
* TODO: adc config: base address
* first channel number (for sid)
* time offset
*/ */
static void adcin_input(struct wrtd_adcin_dev *adcin) static void adcin_input(struct wrtd_adcin_dev *adcin)
{ {
......
software/firmware/fd/fd-i2c.c
View file @ d7de6cf2
...@@ -122,7 +122,6 @@ void mi2c_scan(struct wrtd_fd_dev *fd) ...@@ -122,7 +122,6 @@ void mi2c_scan(struct wrtd_fd_dev *fd)
} }
} }
/* FIXME: this is very inefficient: read several bytes in a row instead */
int fd_eeprom_read(struct wrtd_fd_dev *fd, int i2c_addr, uint32_t offset, int fd_eeprom_read(struct wrtd_fd_dev *fd, int i2c_addr, uint32_t offset,
void *buf, size_t size) void *buf, size_t size)
{ {
......
software/firmware/fd/fd-init.c
View file @ d7de6cf2
...@@ -91,7 +91,6 @@ int fd_reset_again(struct wrtd_fd_dev *fd) ...@@ -91,7 +91,6 @@ int fd_reset_again(struct wrtd_fd_dev *fd)
return 0; return 0;
} }
/* FIXME missing all calibration */
int fd_init(struct wrtd_fd_dev *fd) int fd_init(struct wrtd_fd_dev *fd)
{ {
int err, ch; int err, ch;
...@@ -121,8 +120,6 @@ int fd_init(struct wrtd_fd_dev *fd) ...@@ -121,8 +120,6 @@ int fd_init(struct wrtd_fd_dev *fd)
for (ch = 1; ch <= FD_NUM_CHANNELS; ch++) for (ch = 1; ch <= FD_NUM_CHANNELS; ch++)
fd_gpio_set(fd, FD_GPIO_OUTPUT_EN(ch)); fd_gpio_set(fd, FD_GPIO_OUTPUT_EN(ch));
// todo: read offsets from the EEPROM. I2C should be working OK.
return 0; return 0;
} }
......
software/firmware/fd/fd-pll.c
View file @ d7de6cf2
...@@ -132,7 +132,7 @@ int fd_spi_xfer(struct wrtd_fd_dev *fd, ...@@ -132,7 +132,7 @@ int fd_spi_xfer(struct wrtd_fd_dev *fd,
if(out) if(out)
*out=r; *out=r;
udelay(100); /* FIXME: check */ udelay(100);
return 0; return 0;
} }
......
software/firmware/tdc/wrtd-tdc.c
View file @ d7de6cf2
...@@ -249,10 +249,6 @@ static inline int tdc_wr_sync_timeout(void) ...@@ -249,10 +249,6 @@ static inline int tdc_wr_sync_timeout(void)
/** /**
* Handles input timestamps from all TDC channels. * Handles input timestamps from all TDC channels.
*
* TODO: tdc config: base address
* first channel number (for sid)
* time offset
*/ */
static void tdc_input(struct wrtd_tdc_dev *tdc) static void tdc_input(struct wrtd_tdc_dev *tdc)
{ {
......
software/include/wrtd-common.h
View file @ d7de6cf2
...@@ -23,7 +23,6 @@ ...@@ -23,7 +23,6 @@
/** /**
* WRTD timestamp format * WRTD timestamp format
*/ */
// TODO: maybe distinguish between UTC and TAI
typedef struct wrtd_tstamp { typedef struct wrtd_tstamp {
/** TAI seconds since 1/Jan/1970 (Unix Epoch Time). /** TAI seconds since 1/Jan/1970 (Unix Epoch Time).
This will overflow in 7/Feb/2106... */ This will overflow in 7/Feb/2106... */
......
software/lib/libwrtd-attributes.c
View file @ d7de6cf2
...@@ -324,9 +324,6 @@ enum wrtd_status wrtd_attr_set_alarm_enable(struct wrtd_dev *wrtd, ...@@ -324,9 +324,6 @@ enum wrtd_status wrtd_attr_set_alarm_enable(struct wrtd_dev *wrtd,
wrtd->alarms[idx].alarm.enabled = value; wrtd->alarms[idx].alarm.enabled = value;
/* FIXME: may modify the rule mapping (eg: alarm is placed on cpu,
and is needed to trigger a rule initially placed on a different cpu).
*/
status = wrtd_write_alarm(wrtd, idx, __func__); status = wrtd_write_alarm(wrtd, idx, __func__);
WRTD_RETURN_IF_ERROR(status); WRTD_RETURN_IF_ERROR(status);
......
software/lib/libwrtd-reconfigure.c
View file @ d7de6cf2
...@@ -408,12 +408,6 @@ static enum wrtd_status wrtd_reconfigure_write(struct wrtd_dev *wrtd, ...@@ -408,12 +408,6 @@ static enum wrtd_status wrtd_reconfigure_write(struct wrtd_dev *wrtd,
new_rules[map->rules[i].global_idx].rule = new_rules[map->rules[i].global_idx].rule =
map->rules[i].rule->rule; map->rules[i].rule->rule;
/* Freeze all cpus. */
/* TODO. */
/* For each rule: load stats if different. */
/* TODO. */
wrtd->rules = new_rules; wrtd->rules = new_rules;
for(i = 0; i < wrtd->nbr_rules; i++) { for(i = 0; i < wrtd->nbr_rules; i++) {
...@@ -425,7 +419,7 @@ static enum wrtd_status wrtd_reconfigure_write(struct wrtd_dev *wrtd, ...@@ -425,7 +419,7 @@ static enum wrtd_status wrtd_reconfigure_write(struct wrtd_dev *wrtd,
old_rules[i].rule.conf.id))) old_rules[i].rule.conf.id)))
continue; continue;
status = wrtd_write_rule(wrtd, i, caller_func); status = wrtd_write_rule(wrtd, i, caller_func);
/* FIXME: inconsistent state, free old_rules ? */
WRTD_RETURN_IF_ERROR(status); WRTD_RETURN_IF_ERROR(status);
} }
free(old_rules); free(old_rules);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment