rvlan: do not wait for pid 0

The problem is exposed when we force all intefaces to "justup", in a later commit. Some interfaces will have no children to wait for and would spit this: radiusvlan: wait(0): No child processes Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

rvlan: do not wait for pid 0
The problem is exposed when we force all intefaces to "justup", in a later commit. Some interfaces will have no children to wait for and would spit this: radiusvlan: wait(0): No child processes Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
f5504746 · Alessandro Rubini · 547c41de · f5504746
Commit f5504746 authored Oct 09, 2020 by Alessandro Rubini
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 4 deletions

radiusvlan.c userspace/tools/radiusvlan.c +4 -4

No files found.
--- a/userspace/tools/radiusvlan.c
+++ b/userspace/tools/radiusvlan.c
@@ -332,11 +332,11 @@ int rvlan_fsm(struct rvlan_dev *dev, fd_set *rdset)
 			close(dev->poll_fd);
 		dev->poll_fd = -1;
 		dev->fsm_state = RVLAN_DOWN;
+		if (!dev->pid)
+			break;
 		/* but if we kill our child we must wait reap it */
-		if (dev->pid) {
-			kill(dev->pid, SIGINT);
-			dev->fsm_state = RVLAN_WAIT;
-		}
+		kill(dev->pid, SIGINT);
+		dev->fsm_state = RVLAN_WAIT;
 		/* fall through */

 	case RVLAN_WAIT: