Skip to content

W
White Rabbit Switch - Software
Commit e2f3b909 authored by Maciej Lipinski's avatar Maciej Lipinski Committed by Jean-Claude BAU
Browse files
Options

[HAL] cosmetic changes: remove my TODO comments and fix the stuff, update comment

parent 48fc6d4c
Hide whitespace changes
Inline Side-by-side
Showing with 6 additions and 8 deletions
userspace/wrsw_hal/hal_port_fsm_pll.c
View file @ e2f3b909
......@@ -186,7 +186,7 @@ void hal_port_pll_init_fsm(struct hal_port_state * ps ) {
_fireState(&_portFsm,HAL_PORT_PLL_STATE_UNLOCKED);
}
/* FSM state machine for TX setup on a given port
/* FSM state machine for PLL on a given port
* Returned value:
* 1: when final state has been reached
* 0: when final state has not been reached
......
userspace/wrsw_hal/hal_port_fsm_rx.c
View file @ e2f3b909
......@@ -239,7 +239,7 @@ static int _hal_port_rx_setup_state_validate(void *vpfg, int eventMsk, int isNew
MDIO_LPC_CTRL_DMTD_SOURCE_RXRECCLK,
MDIO_LPC_CTRL);
pcs_writel(ps, BMCR_ANENABLE | BMCR_ANRESTART, MII_BMCR);
//TODO-ML: change to port name
pr_info("wri%d: RX calibration complete at phase %d "
"ps (after %d attempts).\n", ps->hw_index + 1,
phase, rxSetup->attempts);
......
userspace/wrsw_hal/hal_port_fsm_tx.c
View file @ e2f3b909
......@@ -241,11 +241,10 @@ static int _hal_port_tx_setup_state_measure_phase(void *vpfg, int eventMsk, int
int phase_min = txSetup->expected_phase - txSetup->tollerance;
int phase_max = txSetup->expected_phase + txSetup->tollerance;
//TODO-ML: change to name of interface, remove two phases
pr_info("TX Calibration: upd port %d phase %d %d after %d "
pr_info("TX Calibration: upd wri%d phase %d after %d "
"attempts target %d tollerance %d (temp = %.3f degC)\n",
ps->hw_index, txSetup->measured_phase, txSetup->measured_phase,
txSetup->attempts, txSetup->expected_phase, txSetup->tollerance,
ps->hw_index+1, txSetup->measured_phase, txSetup->attempts,
txSetup->expected_phase, txSetup->tollerance,
hal_get_fpga_temperature() / 256.0);
if(_within_range(phase, phase_min, phase_max, 16000)) {
......@@ -420,8 +419,7 @@ static void _load_tx_calibration_file(struct hal_port_state * ps) {
if(cfg_get_int( _calibrationConfig, key_name, &value) )
{
//TODO-ML: change to name
pr_info("cal: %d %d\n", ps->hw_index, value);
pr_info("cal: wri%d %d\n", ps->hw_index+1, value);
ps->lpdc.txSetup->cal_saved_phase = value;
ps->lpdc.txSetup->cal_saved_phase_valid = 1;
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment