rvlan: bugfix: do not obey dotconfig if authorization is denied

The radius server, when denying authorization, may reply as follows: Received response ID 79, code 3, length = 44 Tunnel-Type:0 = 13 Tunnel-Medium-Type:0 = IEEE-802 Framed-Protocol = PPP Service-Type = Framed-User i.e., it misses the vlan number as "Tunnel-Private-Group-Id", while everything else is in place. In this case we should not obey dotconfig, but rather keep the noauth_vlan. Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

rvlan: bugfix: do not obey dotconfig if authorization is denied
The radius server, when denying authorization, may reply as follows: Received response ID 79, code 3, length = 44 Tunnel-Type:0 = 13 Tunnel-Medium-Type:0 = IEEE-802 Framed-Protocol = PPP Service-Type = Framed-User i.e., it misses the vlan number as "Tunnel-Private-Group-Id", while everything else is in place. In this case we should not obey dotconfig, but rather keep the noauth_vlan. Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
8df3687c · Alessandro Rubini · e45473a3 · 8df3687c
Commit 8df3687c authored Oct 11, 2020 by Alessandro Rubini
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

radiusvlan.c userspace/tools/radiusvlan.c +1 -1

No files found.
--- a/userspace/tools/radiusvlan.c
+++ b/userspace/tools/radiusvlan.c
@@ -318,7 +318,7 @@ int rvlan_fsm(struct rvlan_dev *dev, fd_set *rdset)
 				s = strchr(s, '"');
 			if (s)
 				sscanf(s+1, "%i", &dev->chosen_vlan);
-			if (rvlan_obey_dotconfig )
+			if (s && rvlan_obey_dotconfig)
 				dev->chosen_vlan = dev->dotconfig_vlan;
 		}
 		if (verbose)