svec: check_golden temporarily done with

it's not the culprit of the allocation bug

svec: check_golden temporarily done with
it's not the culprit of the allocation bug
5febaac4 · Juan David González Cobas · 2aab3501 · 5febaac4
Commit 5febaac4 authored May 15, 2013 by Juan David González Cobas
Hide whitespace changes
Inline Side-by-side

Showing with 9 additions and 4 deletions

svec-fmc.c kernel/svec-fmc.c +9 -4

No files found.
--- a/kernel/svec-fmc.c
+++ b/kernel/svec-fmc.c
@@ -203,12 +203,17 @@ int svec_fmc_prepare(struct svec_dev *svec, unsigned int fmc_slot)
 	fmc->eeprom_addr = 0x50 + 2 * (1-fmc_slot);
 	fmc->memlen = 0x100000;

+#if 0
 	/* check golden integrity */
-	ret = check_golden(fmc);
-	if (ret) {
-		dev_err(svec->dev, "Bad golden, error %d\n", ret);
-		return ret;
+	/* FIXME: this uses fmc_scan_sdb_tree and de-allocation
+	 * could be wrong at second reprogramming, as it is called
+	 * n times, one per slot */
+	error = check_golden(fmc);
+	if (error) {
+		dev_err(svec->dev, "Bad golden, error %d\n", error);
+		return error;
 	}
+#endif

 	ret = svec_i2c_init(fmc, fmc_slot);
 	if (ret) {