svec: bug: do not free here

107190c0 · Juan David González Cobas · Alessandro Rubini · 723da482 · 107190c0
Commit 107190c0 authored May 15, 2013 by Juan David González Cobas Committed by Alessandro Rubini May 15, 2013
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 6 deletions

svec-fmc.c kernel/svec-fmc.c +6 -6

No files found.
--- a/kernel/svec-fmc.c
+++ b/kernel/svec-fmc.c
@@ -212,6 +212,9 @@ int svec_fmc_prepare(struct svec_dev *svec, unsigned int fmc_slot)
 	svec->fmcs[fmc_slot] = fmc;

 	/* check golden integrity */
+	/* FIXME: this uses fmc_scan_sdb_tree and de-allocation
+	 * could be wrong at second reprogramming, as it is called
+	 * n times, one per slot */
 	ret = check_golden(fmc);
 	if (ret) {
 		dev_err(svec->dev, "Bad golden, error %d\n", ret);
@@ -257,10 +260,7 @@ failed:

 void svec_fmc_destroy(struct svec_dev *svec)
 {
-	if (svec->fmcs) {
-		fmc_device_unregister_n(svec->fmcs, svec->fmcs_n);
-		kfree(svec->fmcs);
-		dev_info(svec->dev, "%d fmc devices unregistered\n",
-						svec->fmcs_n);
-	}
+	fmc_device_unregister_n(svec->fmcs, svec->fmcs_n);
+	dev_info(svec->dev, "%d fmc devices unregistered\n",
+		 svec->fmcs_n);
 }