sw:drv: fix spec_fpga_exit() validation

If the FPGA bitstream has not been discovered correctly, then it does not exist a spec_fpga device. This implies that also the access to the FPGA is forbidden; therefore, the only mechanism to check if we failed to load the FPGA content is to check if the spec_fpga pointer is valid. Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

sw:drv: fix spec_fpga_exit() validation
If the FPGA bitstream has not been discovered correctly, then it does not exist a spec_fpga device. This implies that also the access to the FPGA is forbidden; therefore, the only mechanism to check if we failed to load the FPGA content is to check if the spec_fpga pointer is valid. Signed-off-by: Federico Vaga <federico.vaga@cern.ch>
ee1d4531 · Federico Vaga · 3bb69c00 · ee1d4531
Commit ee1d4531 authored Jul 17, 2019 by Federico Vaga
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

spec-core-fpga.c software/kernel/spec-core-fpga.c +2 -1

No files found.
--- a/software/kernel/spec-core-fpga.c
+++ b/software/kernel/spec-core-fpga.c
@@ -825,6 +825,7 @@ err_valid:
 	iounmap(spec_fpga->fpga);
 err_map:
 	kfree(spec_fpga);
+	spec_gn412x->spec_fpga = NULL;
 	return err;
 }

@@ -832,7 +833,7 @@ int spec_fpga_exit(struct spec_gn412x *spec_gn412x)
 {
 	struct spec_fpga *spec_fpga = spec_gn412x->spec_fpga;

-	if (!spec_fpga_is_valid(spec_gn412x, spec_fpga->meta))
+	if (!spec_fpga)
 		return 0;

 	spec_fpga_dbg_exit(spec_fpga);