move serial validation to the beginning

b443ef8f · Juan David González Cobas · cd90b364 · b443ef8f
Commit b443ef8f authored Dec 17, 2021 by Juan David González Cobas
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 1 deletion

pp.c software/lib/pp.c +6 -1

No files found.
--- a/software/lib/pp.c
+++ b/software/lib/pp.c
@@ -38,8 +38,13 @@ int oau_factory_program_eeprom(unsigned int bus, unsigned int dev, char *serial)
 	static char ser[64];
 	char *ptr;
 	struct ftdi_context *ctx;
-	long s;
+	long serno;
 	
+	serno = strtol(serial, &ptr, 10);
+	if (*ptr != 0 || *serial == 0) {
+		fprintf(stderr, "invalid serial %s\n", serial);
+		return -EINVAL;
+	}
 	if ((ctx = ftdi_new()) == NULL) {
 		fprintf(stderr, "cannot init libftdi, exiting\n");
 		return -ENOMEM;