Commit a2a2adcb authored by Adam Wujek's avatar Adam Wujek 💬

proto-ext-whiterabbit: tune SNMP values

Tune SNMP_MAX_OFFSET_PS and SNMP_MAX_DELTA_RTT_PS
Signed-off-by: Adam Wujek's avatarAdam Wujek <adam.wujek@cern.ch>
parent 395fc56d
......@@ -7,9 +7,8 @@
#define FIX_ALPHA_FRACBITS 40
/* Define threshold values for SNMP */
/* TODO: These values need to be tuned! */
#define SNMP_MAX_OFFSET 1000000
#define SNMP_MAX_DELTA_RTT 1000000
#define SNMP_MAX_OFFSET_PS 1000
#define SNMP_MAX_DELTA_RTT_PS 1000
static const char *servo_name[] = {
[WR_UNINITIALIZED] = "Uninitialized",
......@@ -410,13 +409,13 @@ int wr_servo_update(struct pp_instance *ppi)
s->n_err_state++;
/* Increase number of servo updates with offset exceeded
* SNMP_MAX_OFFSET (Used by SNMP) */
if (abs(s->offset) > SNMP_MAX_OFFSET)
* SNMP_MAX_OFFSET_PS (Used by SNMP) */
if (abs(s->offset) > SNMP_MAX_OFFSET_PS)
s->n_err_offset++;
/* Increase number of servo updates with delta rtt exceeded
* SNMP_MAX_DELTA_RTT (Used by SNMP) */
if (abs(picos_mu_prev - s->picos_mu) > SNMP_MAX_DELTA_RTT)
* SNMP_MAX_DELTA_RTT_PS (Used by SNMP) */
if (abs(picos_mu_prev - s->picos_mu) > SNMP_MAX_DELTA_RTT_PS)
s->n_err_delta_rtt++;
out:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment