Do not raise an error when destroying a Version with assigned issues.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3668 e93f8b46-1217-0410-a6f0-8f06a7374b81

Do not raise an error when destroying a Version with assigned issues.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3668 e93f8b46-1217-0410-a6f0-8f06a7374b81
9ccccb99 · Jean-Philippe Lang · c76b9edf · 9ccccb99 · 9ccccb99
Commit 9ccccb99 authored Apr 11, 2010 by Jean-Philippe Lang
Hide whitespace changes
Inline Side-by-side

Showing with 11 additions and 13 deletions

versions_controller.rb app/controllers/versions_controller.rb +7 -5

version.rb app/models/version.rb +4 -8

No files found.
--- a/app/controllers/versions_controller.rb
+++ b/app/controllers/versions_controller.rb
@@ -80,11 +80,13 @@ class VersionsController < ApplicationController
  end

  def destroy
-    @version.destroy
-    redirect_to :controller => 'projects', :action => 'settings', :tab => 'versions', :id => @project
-  rescue
-    flash[:error] = l(:notice_unable_delete_version)
-    redirect_to :controller => 'projects', :action => 'settings', :tab => 'versions', :id => @project
+    if @version.fixed_issues.empty?
+      @version.destroy
+      redirect_to :controller => 'projects', :action => 'settings', :tab => 'versions', :id => @project
+    else
+      flash[:error] = l(:notice_unable_delete_version)
+      redirect_to :controller => 'projects', :action => 'settings', :tab => 'versions', :id => @project
+    end
  end
  
  def status_by

--- a/app/models/version.rb
+++ b/app/models/version.rb
-# redMine - project management software
-# Copyright (C) 2006  Jean-Philippe Lang
+# Redmine - project management software
+# Copyright (C) 2006-2010  Jean-Philippe Lang
 #
 # This program is free software; you can redistribute it and/or
 # modify it under the terms of the GNU General Public License
@@ -16,10 +16,9 @@
 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.

 class Version < ActiveRecord::Base
-  before_destroy :check_integrity
  after_update :update_issues_from_sharing_change
  belongs_to :project
-  has_many :fixed_issues, :class_name => 'Issue', :foreign_key => 'fixed_version_id'
+  has_many :fixed_issues, :class_name => 'Issue', :foreign_key => 'fixed_version_id', :dependent => :nullify
  acts_as_customizable
  acts_as_attachable :view_permission => :view_files,
                     :delete_permission => :manage_files
@@ -156,10 +155,7 @@ class Version < ActiveRecord::Base
    end
  end
  
-private
-  def check_integrity
-    raise "Can't delete version" if self.fixed_issues.find(:first)
-  end
+  private

  # Update the issue's fixed versions. Used if a version's sharing changes.
  def update_issues_from_sharing_change