Fixes Setting.openid? (#2764).

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2481 e93f8b46-1217-0410-a6f0-8f06a7374b81

Fixes Setting.openid? (#2764).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2481 e93f8b46-1217-0410-a6f0-8f06a7374b81
9525e5f1 · Jean-Philippe Lang · 5966f71c · 9525e5f1 · 9525e5f1
Commit 9525e5f1 authored Feb 19, 2009 by Jean-Philippe Lang
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 1 deletion

setting.rb app/models/setting.rb +1 -1

account_controller_test.rb test/functional/account_controller_test.rb +5 -0

No files found.
--- a/app/models/setting.rb
+++ b/app/models/setting.rb
@@ -141,7 +141,7 @@ class Setting < ActiveRecord::Base
  end
  
  def self.openid?
-    Object.const_defined?(:OpenID) && self['openid'].to_s == '1'
+    Object.const_defined?(:OpenID) && self[:openid].to_i > 0
  end
  
  # Checks if settings have changed since the values were read

--- a/test/functional/account_controller_test.rb
+++ b/test/functional/account_controller_test.rb
@@ -136,6 +136,11 @@ class AccountControllerTest < Test::Unit::TestCase
    assert_equal 'http://openid.example.com/good_user', assigns(:user)[:identity_url]
  end
  
+  def test_setting_openid_should_return_true_when_set_to_true
+    Setting.openid = '1'
+    assert_equal true, Setting.openid?
+  end
+  
  else
    puts "Skipping openid tests."
  end