Respond with 404 instead of 500 when revision/entry is not found in the repository (#7307).

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4710 e93f8b46-1217-0410-a6f0-8f06a7374b81

Respond with 404 instead of 500 when revision/entry is not found in the repository (#7307).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4710 e93f8b46-1217-0410-a6f0-8f06a7374b81
7d0b1b38 · Jean-Philippe Lang · a81953ef · 7d0b1b38 · 7d0b1b38 · 7d0b1b38
Commit 7d0b1b38 authored Jan 14, 2011 by Jean-Philippe Lang
4 changed files
--- a/app/controllers/repositories_controller.rb
+++ b/app/controllers/repositories_controller.rb
@@ -226,7 +226,7 @@ class RepositoriesController < ApplicationController
  end
  def show_error_not_found
-    render_error l(:error_scm_not_found)
+    render_error :message => l(:error_scm_not_found), :status => 404
  end
  # Handler for Redmine::Scm::Adapters::CommandFailed exception

--- a/test/functional/repositories_git_controller_test.rb
+++ b/test/functional/repositories_git_controller_test.rb
@@ -192,7 +192,7 @@ class RepositoriesGitControllerTest < ActionController::TestCase
      @repository.reload
      ['', ' ', nil].each do |r|
        get :revision, :id => 1, :rev => r
-        assert_response 500
+        assert_response 404
        assert_error_tag :content => /was not found/
      end
    end

--- a/test/functional/repositories_mercurial_controller_test.rb
+++ b/test/functional/repositories_mercurial_controller_test.rb
@@ -201,7 +201,7 @@ class RepositoriesMercurialControllerTest < ActionController::TestCase
      @repository.reload
      ['', ' ', nil].each do |r|
        get :revision, :id => 1, :rev => r
-        assert_response 500
+        assert_response 404
        assert_error_tag :content => /was not found/
      end
    end

--- a/test/functional/repositories_subversion_controller_test.rb
+++ b/test/functional/repositories_subversion_controller_test.rb
@@ -168,14 +168,14 @@ class RepositoriesSubversionControllerTest < ActionController::TestCase
    def test_invalid_revision
      get :revision, :id => 1, :rev => 'something_weird'
-      assert_response 500
+      assert_response 404
      assert_error_tag :content => /was not found/
    end
    def test_empty_revision
      ['', ' ', nil].each do |r|
        get :revision, :id => 1, :rev => r
-        assert_response 500
+        assert_response 404
        assert_error_tag :content => /was not found/
      end
    end