Fixed: unable to add a file to an issue without entering a note.

git-svn-id: http://redmine.rubyforge.org/svn/trunk@853 e93f8b46-1217-0410-a6f0-8f06a7374b81

Fixed: unable to add a file to an issue without entering a note.
git-svn-id: http://redmine.rubyforge.org/svn/trunk@853 e93f8b46-1217-0410-a6f0-8f06a7374b81
0e4e0a79 · Jean-Philippe Lang · ecfc4062 · 0e4e0a79 · 0e4e0a79 · 0e4e0a79
Commit 0e4e0a79 authored Oct 19, 2007 by Jean-Philippe Lang
Hide whitespace changes
Inline Side-by-side

Showing with 21 additions and 16 deletions

issues_controller.rb app/controllers/issues_controller.rb +13 -15

issue.rb app/models/issue.rb +3 -1

journal.rb app/models/journal.rb +5 -0

No files found.
--- a/app/controllers/issues_controller.rb
+++ b/app/controllers/issues_controller.rb
@@ -94,21 +94,19 @@ class IssuesController < ApplicationController
  end
  
  def add_note
-    unless params[:notes].empty?
-      journal = @issue.init_journal(self.logged_in_user, params[:notes])
-      if @issue.save
-        params[:attachments].each { |file|
-          next unless file.size > 0
-          a = Attachment.create(:container => @issue, :file => file, :author => logged_in_user)
-          journal.details << JournalDetail.new(:property => 'attachment',
-                                               :prop_key => a.id,
-                                               :value => a.filename) unless a.new_record?
-        } if params[:attachments] and params[:attachments].is_a? Array
-        flash[:notice] = l(:notice_successful_update)
-        Mailer.deliver_issue_edit(journal) if Setting.notified_events.include?('issue_updated')
-        redirect_to :action => 'show', :id => @issue
-        return
-      end
+    journal = @issue.init_journal(User.current, params[:notes])
+    params[:attachments].each { |file|
+      next unless file.size > 0
+      a = Attachment.create(:container => @issue, :file => file, :author => logged_in_user)
+      journal.details << JournalDetail.new(:property => 'attachment',
+                                           :prop_key => a.id,
+                                           :value => a.filename) unless a.new_record?
+    } if params[:attachments] and params[:attachments].is_a? Array
+    if journal.save
+      flash[:notice] = l(:notice_successful_update)
+      Mailer.deliver_issue_edit(journal) if Setting.notified_events.include?('issue_updated')
+      redirect_to :action => 'show', :id => @issue
+      return
    end
    show
  end

--- a/app/models/issue.rb
+++ b/app/models/issue.rb
@@ -98,8 +98,10 @@ class Issue < ActiveRecord::Base
                                                      :old_value => @custom_values_before_change[c.custom_field_id],
                                                      :value => c.value)
      }      
-      @current_journal.save unless @current_journal.details.empty? and @current_journal.notes.empty?
+      @current_journal.save
    end
+    # Save the issue even if the journal is not saved (because empty)
+    true
  end
  
  def after_save

--- a/app/models/journal.rb
+++ b/app/models/journal.rb
@@ -28,4 +28,9 @@ class Journal < ActiveRecord::Base
                     :include => :issue,
                     :project_key => "#{Issue.table_name}.project_id",
                     :date_column => "#{Issue.table_name}.created_on"
+  
+  def save
+    # Do not save an empty journal
+    (details.empty? && notes.blank?) ? false : super
+  end
 end