Fixed: CLI-supplied defaults should not be applied when replying to an issue (#7195).

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4576 e93f8b46-1217-0410-a6f0-8f06a7374b81

Fixed: CLI-supplied defaults should not be applied when replying to an issue (#7195).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4576 e93f8b46-1217-0410-a6f0-8f06a7374b81
03d4ecbb · Jean-Philippe Lang · 21c0b868 · 03d4ecbb · 03d4ecbb
Commit 03d4ecbb authored Dec 29, 2010 by Jean-Philippe Lang
Hide whitespace changes
Inline Side-by-side

Showing with 11 additions and 0 deletions

mail_handler.rb app/models/mail_handler.rb +3 -0

mail_handler_test.rb test/unit/mail_handler_test.rb +8 -0

No files found.
--- a/app/models/mail_handler.rb
+++ b/app/models/mail_handler.rb
@@ -148,6 +148,9 @@ class MailHandler < ActionMailer::Base
      raise UnauthorizedAction unless user.allowed_to?(:add_issue_notes, issue.project) || user.allowed_to?(:edit_issues, issue.project)
    end
    
+    # ignore CLI-supplied defaults for new issues
+    @@handler_options[:issue].clear
+    
    journal = issue.init_journal(user, cleaned_up_text_body)
    issue.safe_attributes = issue_attributes_from_keywords(issue)
    issue.safe_attributes = {'custom_field_values' => custom_field_values_from_keywords(issue)}

--- a/test/unit/mail_handler_test.rb
+++ b/test/unit/mail_handler_test.rb
@@ -327,6 +327,14 @@ class MailHandlerTest < ActiveSupport::TestCase
    assert_equal 1, ActionMailer::Base.deliveries.size
  end
  
+  def test_add_issue_note_should_not_set_defaults
+    journal = submit_email('ticket_reply.eml', :issue => {:tracker => 'Support request', :priority => 'High'})
+    assert journal.is_a?(Journal)
+    assert_match /This is reply/, journal.notes
+    assert_equal 'Feature request', journal.issue.tracker.name
+    assert_equal 'Normal', journal.issue.priority.name
+  end
+  
  def test_reply_to_a_message
    m = submit_email('message_reply.eml')
    assert m.is_a?(Message)