drivers: fmc: eeprom: Improve error checking

nvmem_device_get() may return an error pointed instead of NULL, thus check for it. Picked from the changes done by Mathis Marion for Oscimp-WRTD project. Signed-off-by: Vaibhav Gupta <vaibhav.gupta@cern.ch>

drivers: fmc: eeprom: Improve error checking
nvmem_device_get() may return an error pointed instead of NULL, thus check for it. Picked from the changes done by Mathis Marion for Oscimp-WRTD project. Signed-off-by: Vaibhav Gupta <vaibhav.gupta@cern.ch>
bccd4cbc · Vaibhav Gupta · a3bc508d · bccd4cbc
Commit bccd4cbc authored Sep 07, 2022 by Vaibhav Gupta
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

fmc-eeprom.c drivers/fmc/fmc-eeprom.c +4 -1

No files found.
--- a/drivers/fmc/fmc-eeprom.c
+++ b/drivers/fmc/fmc-eeprom.c
@@ -105,12 +105,15 @@ ssize_t fmc_slot_eeprom_read(struct fmc_slot *slot,
 		snprintf(nvmem_name, len, "%s%d",
 			 dev_name(&slot->eeprom->dev), idx);
 		nvmem = nvmem_device_get(&slot->dev, nvmem_name);
-		if (nvmem) {
+		if (!IS_ERR_OR_NULL(nvmem)) {
 			err = nvmem_device_read(nvmem, offset, count, buf);
 #if KERNEL_VERSION(5, 1, 0) <= LINUX_VERSION_CODE
 			nvmem_device_put(nvmem);
 #endif
 		}
+		else {
+			err = PTR_ERR(nvmem);
+		}
 		kfree(nvmem_name);
 	}
 #else