Skip to content

F
FMC Bus
Commit ac1a3993 authored by Dan Carpenter's avatar Dan Carpenter Committed by Alessandro Rubini
Browse files
Options

FMC: fix error handling in probe() function 

The call to kzalloc() wasn't checked.
The dev_info() message dereferenced freed memory on error.
Signed-off-by: 's avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: Alessandro Rubini's avatarAlessandro Rubini <rubini@gnudd.com>
Signed-off-by: 's avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5de8348d
Hide whitespace changes
Inline Side-by-side
Showing with 11 additions and 6 deletions
kernel/fmc-chardev.c
View file @ ac1a3993
......@@ -136,6 +136,8 @@ static int fc_probe(struct fmc_device *fmc)
/* Create a char device: we want to create it anew */
fc = kzalloc(sizeof(*fc), GFP_KERNEL);
if (!fc)
return -ENOMEM;
fc->fmc = fmc;
fc->misc.minor = MISC_DYNAMIC_MINOR;
fc->misc.fops = &fc_fops;
......@@ -143,15 +145,18 @@ static int fc_probe(struct fmc_device *fmc)
spin_lock(&fc_lock);
ret = misc_register(&fc->misc);
if (ret < 0) {
kfree(fc->misc.name);
kfree(fc);
} else {
list_add(&fc->list, &fc_devices);
}
if (ret < 0)
goto err_unlock;
list_add(&fc->list, &fc_devices);
spin_unlock(&fc_lock);
dev_info(&fc->fmc->dev, "Created misc device \"%s\"\n",
fc->misc.name);
return 0;
err_unlock:
spin_unlock(&fc_lock);
kfree(fc->misc.name);
kfree(fc);
return ret;
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment