Skip to content

F
FMC Bus
Commit 16ff2151 authored by Alessandro Rubini's avatar Alessandro Rubini
Browse files
Options

fmc-trivial: use validate and generic parameters

parent ed62f109
Hide whitespace changes
Inline Side-by-side
Showing with 11 additions and 0 deletions
kernel/fmc-trivial.c
View file @ 16ff2151
...@@ -8,6 +8,8 @@ ...@@ -8,6 +8,8 @@
static char *t_filename; static char *t_filename;
module_param_named(file, t_filename, charp, 0444); module_param_named(file, t_filename, charp, 0444);
static struct fmc_driver t_drv; /* initialized later */
irqreturn_t t_handler(int irq, void *dev_id) irqreturn_t t_handler(int irq, void *dev_id)
{ {
struct fmc_device *fmc = dev_id; struct fmc_device *fmc = dev_id;
...@@ -20,6 +22,11 @@ irqreturn_t t_handler(int irq, void *dev_id) ...@@ -20,6 +22,11 @@ irqreturn_t t_handler(int irq, void *dev_id)
int t_probe(struct fmc_device *fmc) int t_probe(struct fmc_device *fmc)
{ {
int ret; int ret;
int index;
index = fmc->op->validate(fmc, &t_drv);
if (index < 0)
return -EINVAL; /* not our device: invalid */
ret = fmc->op->irq_request(fmc, t_handler, "fmc-trivial", 0); ret = fmc->op->irq_request(fmc, t_handler, "fmc-trivial", 0);
if (ret < 0) if (ret < 0)
...@@ -29,6 +36,8 @@ int t_probe(struct fmc_device *fmc) ...@@ -29,6 +36,8 @@ int t_probe(struct fmc_device *fmc)
ret = fmc->op->reprogram(fmc, ""); ret = fmc->op->reprogram(fmc, "");
if (ret < 0) if (ret < 0)
fmc->op->irq_free(fmc); fmc->op->irq_free(fmc);
/* FIXME: reprogram LM32 too */
return ret; return ret;
} }
...@@ -45,6 +54,8 @@ static struct fmc_driver t_drv = { ...@@ -45,6 +54,8 @@ static struct fmc_driver t_drv = {
/* no table, as the current match just matches everything */ /* no table, as the current match just matches everything */
}; };
FMC_MODULE_PARAMS(t_drv); /* We accept the generic parameters */
static int t_init(void) static int t_init(void)
{ {
int ret; int ret;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment