sw: Added clarification comments in sfp_eeprom.py

7f121843 · Theodor-Adrian Stana · 4cf90a9b · 7f121843
Commit 7f121843 authored Nov 05, 2014 by Theodor-Adrian Stana
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

sfp_eeprom.py pts/python/sfp_eeprom.py +4 -1

No files found.
--- a/pts/python/sfp_eeprom.py
+++ b/pts/python/sfp_eeprom.py
@@ -206,9 +206,12 @@ def main(bus,tname,inf,log):
        i2c = COpenCoresI2C(bus, SFP_EEPROM_BASE, 39);
        eeprom = EEPROM_SFP(i2c, SFP_EEPROM_I2C_ADDR);

+        # Read SFP I2C identifier value, which should return 0x03 for an SFP or SFP+ connector type
+        # No other connectors are currently supported
+        # For more information, see INF-8074 (SFP) and SFF-8472 (SFP+)
        type = eeprom.rd_reg8(0x0);

-        if (type == 3) :
+        if (type == 0x03):
            inf.write("SFP type (0x%02x) is correct\n" % type)
        else:
            msg = "ERROR: SFP-EEPROM: Wrong connector type (0x%02x). It should be 0x03." % type