Commit 7c829ef5 authored by Alessandro Rubini's avatar Alessandro Rubini Committed by Grzegorz Daniluk

softpll stats: remove valid bit

"char valid" in a structure of integer makes alignment problems
(because we are accessing it from a different CPU we'd better not have
holes).

Also, there is no inherent consistency needed here, and this valid bit
is racy anyways. We could solve it with a sequence number, if any, but
let's avoid it altogether by now.
Signed-off-by: Alessandro Rubini's avatarAlessandro Rubini <rubini@gnudd.com>
parent bf199e49
......@@ -652,7 +652,6 @@ void spll_update()
/* for WRS update .stat section in memory */
temp_stats.magic = 0x5b1157a7;
temp_stats.ver = 1;
temp_stats.valid = 0;
temp_stats.mode = softpll.mode;
temp_stats.irq_cnt = irq_count;
temp_stats.seq_state = softpll.seq_state;
......@@ -662,9 +661,7 @@ void spll_update()
temp_stats.H_y = softpll.helper.pi.y;
temp_stats.M_y = softpll.mpll.pi.y;
temp_stats.del_cnt = softpll.delock_count;
stats_ptr->valid = 0;
*stats_ptr = temp_stats;
stats_ptr->valid = 1;
#endif
}
......
......@@ -133,7 +133,6 @@ void check_vco_frequencies();
struct spll_stats {
int magic; /* 0x5b1157a7 = SPLLSTAT ?;)*/
int ver; /* version of the structure */
char valid; /* is the stat info valid */
int mode;
int irq_cnt;
int seq_state;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment