more cleanup of prototypes

This time I added -Wmissing-prototypes and fixed accordingly. Again, this used to be part of -Wall and I'm disgusted by it not being so any more. What does "all" mean, then? Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

more cleanup of prototypes
This time I added -Wmissing-prototypes and fixed accordingly. Again, this used to be part of -Wall and I'm disgusted by it not being so any more. What does "all" mean, then? Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
360c71cd · Alessandro Rubini · be2bd234 · 360c71cd · 360c71cd · 360c71cd
Commit 360c71cd authored Jul 26, 2015 by Alessandro Rubini
10 changed files
--- a/Makefile
+++ b/Makefile
@@ -77,7 +77,7 @@ obj-$(CONFIG_WR_NODE) += sdb-lib/libsdbfs.a
 cflags-$(CONFIG_WR_NODE) += -Isdb-lib

 CFLAGS = $(CFLAGS_PLATFORM) $(cflags-y) -Wall -Wstrict-prototypes \
-	-ffunction-sections -fdata-sections -Os \
+	-ffunction-sections -fdata-sections -Os -Wmissing-prototypes \
 	-include include/trace.h -ggdb

 LDFLAGS = $(LDFLAGS_PLATFORM) \

--- a/check-error.c
+++ b/check-error.c
@@ -9,6 +9,9 @@
 extern void __you_should_not_call_printf_from_wrpc_sw(void);
 extern void __you_should_not_divide_ll_in_wrpc_sw(void);

+long long __moddi3 (long long A, long long B);
+long long __divdi3 (long long A, long long B);
+
 int printf(const char *fmt, ...)
 {
 	__you_should_not_call_printf_from_wrpc_sw();

--- a/dev/i2c.c
+++ b/dev/i2c.c
@@ -10,6 +10,7 @@
 #include "types.h"
 #include "board.h"
 #include "syscon.h"
+#include "i2c.h"

 #define I2C_DELAY 300


--- a/dev/pps_gen.c
+++ b/dev/pps_gen.c
@@ -82,7 +82,7 @@ void shw_pps_gen_set_time(uint64_t seconds, uint32_t nanoseconds, int counter)
 		ppsg_write(ESCR, (ppsg_read(ESCR) & 0xffffffe7) | PPSG_ESCR_NSEC_SET);
 }

-uint64_t pps_get_utc(void)
+static uint64_t pps_get_utc(void)
 {
 	uint64_t out;
 	uint32_t low, high;

--- a/dev/rxts_calibrator.c
+++ b/dev/rxts_calibrator.c
@@ -19,6 +19,7 @@
 #include "wrc_ptp.h"
 #include "storage.h"
 #include "ptpd_netif.h"
+#include "rxts_calibrator.h"

 /* New calibrator for the transition phase value. A major pain in the ass for
   the folks who frequently rebuild their gatewares. The idea is described

--- a/dev/sdb-storage.c
+++ b/dev/sdb-storage.c
@@ -14,6 +14,7 @@

 #include "types.h"
 #include "i2c.h"
+#include "onewire.h"
 #include <sdb.h>

 #define SDBFS_BIG_ENDIAN

--- a/include/irq.h
+++ b/include/irq.h
@@ -9,5 +9,6 @@ static inline void clear_irq(void)

 void disable_irq(void);
 void enable_irq(void);
+void _irq_entry(void);

 #endif
--- a/include/rxts_calibrator.h
+++ b/include/rxts_calibrator.h
@@ -11,7 +11,7 @@
 #define __RXTS_CALIBRATOR_H

 void rxts_calibration_start(void);
-int rxts_calibration_update(int *t24p_value);
+int rxts_calibration_update(uint32_t *t24p_value);
 int measure_t24p(uint32_t *value);
 int calib_t24p(int mode, uint32_t *value);


--- a/monitor/monitor_ppsi.c
+++ b/monitor/monitor_ppsi.c
@@ -32,7 +32,7 @@ struct pp_instance *ppi = &ppi_static;
 static void wrc_mon_std_servo(void);

 #define PRINT64_FACTOR	1000000000LL
-char* print64(uint64_t x)
+static char* print64(uint64_t x)
 {
 	uint32_t h_half, l_half;
 	static char buf[2*10+1];	//2x 32-bit value + \0
@@ -47,7 +47,7 @@ char* print64(uint64_t x)

 }

-int wrc_mon_status(void)
+static int wrc_mon_status(void)
 {
 	struct wr_servo_state *s =
 			&((struct wr_data *)ppi->ext_data)->servo_state;

--- a/softpll/softpll_ng.c
+++ b/softpll/softpll_ng.c
@@ -395,11 +395,6 @@ void spll_stop_channel(int channel)
 	mpll_stop(&s->aux[channel - 1].pll.dmtd);
 }

-int spll_ext_locked(void)
-{
-	return external_locked( (struct spll_external_state *) &softpll.ext);
-}
-
 int spll_check_lock(int channel)
 {
 	if (!channel)
@@ -531,7 +526,7 @@ static inline void aux_set_channel_status(int channel, int locked)
 		SPLL->OCCR |= (SPLL_OCCR_OUT_LOCK_W((1 << channel)));
 }

-int spll_update_aux_clocks(void)
+static int spll_update_aux_clocks(void)
 {
 	int ch;