vme_funct_match: use standard way to write processes.

ab6edbb9 · Tristan Gingold · 1d0d3d91 · ab6edbb9 · ab6edbb9
Commit ab6edbb9 authored Nov 27, 2017 by Tristan Gingold
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 6 deletions

GD-vme64x-core-review.txt doc/review-2017-11-13/GD-vme64x-core-review.txt +1 -1

vme_funct_match.vhd hdl/rtl/vme_funct_match.vhd +7 -5

No files found.
--- a/doc/review-2017-11-13/GD-vme64x-core-review.txt
+++ b/doc/review-2017-11-13/GD-vme64x-core-review.txt
@@ -96,7 +96,7 @@
  Instead of clearing the registers at every risinge_edge, and having null in
  rst_n_i='0', please clear the registers when rst_n_i ='0' and add another
  "else" if you want to clear them every time decode_start_i='0'.
-  OK.
+  Done.
 - line 133:
  What's this construction??:
  mask(c_ADEM_M) := g_ADEM(s_function_sel)(c_ADEM_M);

--- a/hdl/rtl/vme_funct_match.vhd
+++ b/hdl/rtl/vme_funct_match.vhd
@@ -94,12 +94,10 @@ begin
  process (clk_i)
  begin
    if rising_edge(clk_i) then
-      s_function_sel <= 0;
-      s_function_sel_valid <= '0';
-      s_decode_start_1 <= '0';
-
      if rst_n_i = '0' then
-        null;
+        s_decode_start_1 <= '0';
+        s_function_sel <= 0;
+        s_function_sel_valid <= '0';
      elsif decode_start_i = '1' then
        s_decode_start_1 <= '1';
        for i in 0 to 7 loop
@@ -109,6 +107,10 @@ begin
            exit;
          end if;
        end loop;
+      else
+        s_decode_start_1 <= '0';
+        s_function_sel <= 0;
+        s_function_sel_valid <= '0';
      end if;
    end if;
  end process;