Skip to content

S
Simple VME FMC Carrier SVEC
Commit 5f2bd7f5 authored by Federico Vaga's avatar Federico Vaga
Browse files
Options

kernel: do not remove device 

Removing the device instance is wrong. The SVEC module has a little
System FPGA where the Application FPGA programmer lives.
The System FPGA is the one that we drive with the SVEC driver
when we program the Application FPGA. So, there is no need to
destroy the SVEC device instance.
Signed-off-by: Federico Vaga's avatarFederico Vaga <federico.vaga@vaga.pv.it>
parent 83888214
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 16 deletions
doc/svec-device.rst
View file @ 5f2bd7f5
......@@ -38,11 +38,6 @@ The complete programming procedure is:
#. unlock the programming procedure by writing "unlock" in ``AFPGA/lock``
#. write the FPGA bit-stream in the character device ``/dev/svec.<N>``
Once the programming procedure terminates, the SVEC device instance is not
valid anymore. The new Application FPGA represents a new SVEC device
instance, so the SVEC device instance used to program the FPGA must be removed
and the user must load a new SVEC device instance.
Files
=====
......
kernel/svec-core.c
View file @ 5f2bd7f5
......@@ -462,17 +462,6 @@ static int svec_close(struct inode *inode, struct file *file)
dev_info(&svec->dev,
"a new application FPGA has been programmed\n");
/* There are no more user check if we can safely remove the device */
/* TODO do some checks */
/* I'm not 100% sure of this*/
device_unregister(svec->dev.parent);
dev_info(&svec->dev,
"a new application FPGA has been programmed\n");
dev_info(&svec->dev,
"self-destroying this Linux device driver instance\n");
return err;
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment