Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
S
Simple VME FMC Carrier SVEC
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
14
Issues
14
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Wiki
Wiki
image/svg+xml
Discourse
Discourse
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Projects
Simple VME FMC Carrier SVEC
Commits
33de4aa7
Commit
33de4aa7
authored
Feb 12, 2020
by
Federico Vaga
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
sw:drv: bugfix missing copy_from_user
Signed-off-by:
Federico Vaga
<
federico.vaga@cern.ch
>
parent
92b3092e
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
13 additions
and
6 deletions
+13
-6
svec-core.c
software/kernel/svec-core.c
+13
-6
No files found.
software/kernel/svec-core.c
View file @
33de4aa7
...
...
@@ -77,22 +77,29 @@ out:
return
err
;
}
#define VBRIDGE_DBG_FW_BUF_LEN 128
static
ssize_t
svec_dbg_fw_write
(
struct
file
*
file
,
const
char
__user
*
buf
,
size_t
count
,
loff_t
*
ppos
)
{
struct
svec_dev
*
svec_dev
=
file
->
private_data
;
char
buf_l
[
VBRIDGE_DBG_FW_BUF_LEN
];
int
err
;
if
(
!
buf
||
!
count
)
{
dev_err
(
&
svec_dev
->
vdev
->
dev
,
"Invalid input
\n
"
);
if
(
VBRIDGE_DBG_FW_BUF_LEN
<
count
)
{
dev_err
(
&
svec_dev
->
vdev
->
dev
,
"Firmware name too long max %u
\n
"
,
VBRIDGE_DBG_FW_BUF_LEN
);
return
-
EINVAL
;
}
err
=
svec_fw_load
(
svec_dev
,
buf
);
err
=
copy_from_user
(
buf_l
,
buf
,
VBRIDGE_DBG_FW_BUF_LEN
);
if
(
err
)
return
err
;
return
count
;
return
-
EFAULT
;
err
=
svec_fw_load
(
svec_dev
,
buf_l
);
return
err
?
err
:
count
;
}
static
const
struct
file_operations
svec_dbg_fw_ops
=
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment