Commit ee732d5e authored by Federico Vaga's avatar Federico Vaga

tools:vuart: do not use default offset value

There are no rule or specification that say that the VUART
offset for the White-rabbit core is at 0x20500. This is just a very
common value but it is not true in all cases.

Setting a default value based on fashion is not correct. Users
of bitstreams with other offsets expect the default to work because
they do not know what to do actually.

By removing the default we force the users to verify first where
the VUART is located.

Today SDB gives this information and once it is known, lazy people can
wrap the command in a script and pretending that it is the default.
Signed-off-by: Federico Vaga's avatarFederico Vaga <federico.vaga@cern.ch>
parent 08064303
......@@ -96,7 +96,7 @@ void term_main(int keep_term)
int main(int argc, char **argv)
{
int bus = -1, dev_fn = -1, c;
uint32_t vuart_base = __WR_VUART_OFFSET;
uint32_t vuart_base = ~0;
int keep_term = 0;
while ((c = getopt (argc, argv, "b:d:u:kV")) != -1)
......@@ -123,15 +123,23 @@ int main(int argc, char **argv)
"Use: \"%s [-V] [-b bus] [-d devfn] "
"[-u VUART base] [-k]\"\n", argv[0]);
fprintf(stderr,
"By default, the first available SPEC "
"is used and the VUART is assumed at 0x%x.\n"
"-k option keeps the prev terminal config\n",
"By default, the first available SPEC is used\n");
fprintf(stderr,
"-k option keeps the prev terminal config\n");
fprintf(stderr,
"-u to set the VUART offset within "
"the bitstream. Typically at 0x%x\n",
__WR_VUART_OFFSET);
exit(1);
}
}
card = spec_open(bus, dev_fn);
if (vuart_base == ~0) {
fprintf(stderr, "\"-u\" parameter is mandatory\n");
exit(1);
}
card = spec_open(bus, dev_fn);
if(!card)
{
fprintf(stderr, "Can't detect a SPEC card under the given "
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment