Signed-off-by: Aurelio Colosimo <aurelio@aureliocolosimo.it>

Due to multilink needs, those variables are no more global but can be defined
as a different setting for each port. They will be set in a /etc/ppsi.conf file,
which is not yet handled, but will be soon.
struct pp_runtime_opts will contain only multiport settings.
If the /etc/ppsi.conf file is not found or not handled (like it is at present),
ppsi accepts and properly handles the same cmd line options as in the past.
Signed-off-by: Aurelio Colosimo <aurelio@aureliocolosimo.it>

pp_diag_allow(ppi, thing, level) can be used as a conditional
to mask off diagnostic prints that cannot be individually
written as pp_diag()  (this mainly applies to frame dumping, introduced
in later commits).
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

I'm adding generic dump code to the receive and send code paths,
so I need the length of the incoming frame when first "unpacking" it,
to dump the whole frame using code from tools/dump-funcs.c
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Unfortunately, we need to pass ppi to the time operations, so we
can have per-instance logging options. This is the second time I found
the need for such extra argument: the first time I worked it around, now
I surrender.

Actually, I don't find it unlikely for a multi-instance process to
spit a lot of diagnostics about timestamps. A developer may need to
filter messages according to who is tiemstamping/timing out etc.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This converts fsm.c to use the new diagnostics. We keep printing
the timestamp for fsm messages, which means diag.c::__pp_diag is
somehow duplicated here (in what was called pp_timed_printf).

This is the output with "-d 1" (or "-d "100") on a forced-slave ("-g"):

  diag level: 10000000
  diag-fsm-1-eth0: 1362666577.043: ENTER initializing, packet len 0
  diag-fsm-1-eth0: 1362666577.045: LEAVE initializing (next:   4 in 0 ms)
  diag-fsm-1-eth0: 1362666577.045: ENTER listening, packet len 0
  diag-fsm-1-eth0: 1362666577.045: listening: reenter in 11999 ms
  diag-fsm-1-eth0: 1362666587.204: listening: reenter in 1840 ms
  diag-fsm-1-eth0: 1362666588.388: LEAVE listening (next:   9 in 0 ms)
  diag-fsm-1-eth0: 1362666588.388: ENTER slave, packet len 44
  diag-fsm-1-eth0: 1362666588.389: slave: reenter in 889 ms
  diag-fsm-1-eth0: 1362666589.219: slave: reenter in 59 ms
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

By passing "-V -d 001" now I get level-1 diagnostics for frames (i.e.
sending and receiving):

Slave:

   diag-frames-1-eth0: RECV 44 bytes at 1362665418.025198568 (type 0)
   diag-frames-1-eth0: RECV 44 bytes at 1362665418.025970153 (type 8)
   diag-frames-1-eth0: SENT 44 bytes at 1362665416.806670510 (delay_req)
   diag-frames-1-eth0: RECV 54 bytes at 1362665416.808217467 (type 9)

Master:

   diag-frames-1-eth0: SENT 64 bytes at 1362665415.430554014 (announce)
   diag-frames-1-eth0: SENT 44 bytes at 1362665416.612818573 (sync)
   diag-frames-1-eth0: SENT 44 bytes at 1362665416.613056524 (follow_up)
   diag-frames-1-eth0: RECV 44 bytes at 1362665416.807983194 (type 1)
   diag-frames-1-eth0: SENT 54 bytes at 1362665416.808206209 (delay_resp)

(note: we don't tell names at receive time because the frame is still
to be validated).
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This adds the interface name where the error happened (we'll need it
for multi-link setups, that Aurelio is going to implement soon).

Moreover, this kills the last pp_diag_error call
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

fsm.c is the only user of timed_printf, and actually I don't expect
other messages to need timing (since we know the time from the fsm
states).

I may repent, I'm aware. But at this point I'm killing diag-yes, to
make the one and true diagnostic environment, without duplications and
conflicts.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Since diagnostics about the fsm is only used in fsm.c, move it there
so we have less global context and we are all happier.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

fsm.c corrently decodes the received frame, and error management is
built in (even if code in msg.c still needs to be audited to be more
careful about rogue frames).  However, when a received frame is in
error, fsm.c cannot return to the caller because it doesn't know the
current delay. Thus, zero the frame and call the current status, so
we have back a recalculated ppi->next_delay.

Meanwhile, mask with pp_verbose_frames the diagnostic message for
received frames -- and be more careful with accessing it's data.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

I'm going to split diagnostics into groups based on flags. And
with different diagnostics for each pp instance, to be ready to
debug multi-link situations.  This commit adds the flags in the proper
places and the first flag value, used in the next commit.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Too many messages are confusing: let's make a state change more
visible than a re-enter of the same state.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

If the state just executed switched to a new state, we should enter
that new stat immediately, and ignore ppi->next_delay.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This is accomplished by making msg_unpack_header return an error code
(and by warning users who ignore it).  We *really* don't need our
own frames back -- even if they come from a different port.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

ppsi handles the CONFIG_PPSI_RUNTIME_VERBOSITY, which make it reduce
executable size when runtime verbosity change is not required.
Signed-off-by: Aurelio Colosimo <aurelio@aureliocolosimo.it>

This is a major patch, because header files are renamed, and
the header directory with them. Still, no functional change is there.

the "ppi" object instance should consistently be the first argument of
functions that receive it. Besides being more consistent, it's smaller
and faster too (on processors with more than 4 registers, I mean).
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

These remove style warnings and errors, mostly mine. External files
(such as hw files in arch-spec and syscall stuff in bare-linux) have
not been fixed and should not be, in my opinion.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

All files called state-*.c are individual states: rename accordingly
to preven confusion.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
Acked-by: Aurelio Colosimo <aurelio@aureliocolosimo.it>

While the code layout comes from ptp-proposal, this is a different
package, now called pptp for "Portable PTP".
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
Acked-by: Aurelio Colosimo <aurelio@aureliocolosimo.it>

code was pruned from specific "ptp-proposal" protocol and the
skeleton of IEEE-1588 states was made. Next step is to insert,
step by step, the structs defined in ptpd. Still something needs
to be removed or renamed, but this should be a fair starting point.